Simon Glass | 793dca3 | 2019-10-31 07:42:57 -0600 | [diff] [blame] | 1 | #!/usr/bin/env python3 |
Tom Rini | 83d290c | 2018-05-06 17:58:06 -0400 | [diff] [blame] | 2 | # SPDX-License-Identifier: GPL-2.0+ |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 3 | # |
| 4 | # Author: Masahiro Yamada <yamada.masahiro@socionext.com> |
| 5 | # |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 6 | |
| 7 | """ |
| 8 | Move config options from headers to defconfig files. |
| 9 | |
Simon Glass | 5c72c0e | 2021-07-21 21:35:51 -0600 | [diff] [blame] | 10 | See doc/develop/moveconfig.rst for documentation. |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 11 | """ |
| 12 | |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 13 | from argparse import ArgumentParser |
Markus Klotzbuecher | b3192f4 | 2020-02-12 20:46:44 +0100 | [diff] [blame] | 14 | import asteval |
Simon Glass | 99b6660 | 2017-06-01 19:39:03 -0600 | [diff] [blame] | 15 | import collections |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 16 | from contextlib import ExitStack |
Masahiro Yamada | 8ba1f5d | 2016-07-25 19:15:24 +0900 | [diff] [blame] | 17 | import copy |
Masahiro Yamada | f2f6981 | 2016-07-25 19:15:25 +0900 | [diff] [blame] | 18 | import difflib |
Simon Glass | 84067a5 | 2021-12-18 08:09:45 -0700 | [diff] [blame] | 19 | import doctest |
Masahiro Yamada | c8e1b10 | 2016-05-19 15:52:07 +0900 | [diff] [blame] | 20 | import filecmp |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 21 | import fnmatch |
Masahiro Yamada | 0dbc9b5 | 2016-10-19 14:39:54 +0900 | [diff] [blame] | 22 | import glob |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 23 | import multiprocessing |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 24 | import os |
Simon Glass | 793dca3 | 2019-10-31 07:42:57 -0600 | [diff] [blame] | 25 | import queue |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 26 | import re |
| 27 | import shutil |
| 28 | import subprocess |
| 29 | import sys |
| 30 | import tempfile |
Simon Glass | d73fcb1 | 2017-06-01 19:39:02 -0600 | [diff] [blame] | 31 | import threading |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 32 | import time |
Simon Glass | 84067a5 | 2021-12-18 08:09:45 -0700 | [diff] [blame] | 33 | import unittest |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 34 | |
Simon Glass | 0ede00f | 2020-04-17 18:09:02 -0600 | [diff] [blame] | 35 | from buildman import bsettings |
| 36 | from buildman import kconfiglib |
| 37 | from buildman import toolchain |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 38 | |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 39 | SHOW_GNU_MAKE = 'scripts/show-gnu-make' |
| 40 | SLEEP_TIME=0.03 |
| 41 | |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 42 | STATE_IDLE = 0 |
| 43 | STATE_DEFCONFIG = 1 |
| 44 | STATE_AUTOCONF = 2 |
Joe Hershberger | 96464ba | 2015-05-19 13:21:17 -0500 | [diff] [blame] | 45 | STATE_SAVEDEFCONFIG = 3 |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 46 | |
| 47 | ACTION_MOVE = 0 |
Masahiro Yamada | cc00829 | 2016-05-19 15:51:56 +0900 | [diff] [blame] | 48 | ACTION_NO_ENTRY = 1 |
Masahiro Yamada | 916224c | 2016-08-22 22:18:21 +0900 | [diff] [blame] | 49 | ACTION_NO_ENTRY_WARN = 2 |
| 50 | ACTION_NO_CHANGE = 3 |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 51 | |
| 52 | COLOR_BLACK = '0;30' |
| 53 | COLOR_RED = '0;31' |
| 54 | COLOR_GREEN = '0;32' |
| 55 | COLOR_BROWN = '0;33' |
| 56 | COLOR_BLUE = '0;34' |
| 57 | COLOR_PURPLE = '0;35' |
| 58 | COLOR_CYAN = '0;36' |
| 59 | COLOR_LIGHT_GRAY = '0;37' |
| 60 | COLOR_DARK_GRAY = '1;30' |
| 61 | COLOR_LIGHT_RED = '1;31' |
| 62 | COLOR_LIGHT_GREEN = '1;32' |
| 63 | COLOR_YELLOW = '1;33' |
| 64 | COLOR_LIGHT_BLUE = '1;34' |
| 65 | COLOR_LIGHT_PURPLE = '1;35' |
| 66 | COLOR_LIGHT_CYAN = '1;36' |
| 67 | COLOR_WHITE = '1;37' |
| 68 | |
Simon Glass | f3b8e64 | 2017-06-01 19:39:01 -0600 | [diff] [blame] | 69 | AUTO_CONF_PATH = 'include/config/auto.conf' |
Simon Glass | d73fcb1 | 2017-06-01 19:39:02 -0600 | [diff] [blame] | 70 | CONFIG_DATABASE = 'moveconfig.db' |
Simon Glass | f3b8e64 | 2017-06-01 19:39:01 -0600 | [diff] [blame] | 71 | |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 72 | CONFIG_LEN = len('CONFIG_') |
Simon Glass | f3b8e64 | 2017-06-01 19:39:01 -0600 | [diff] [blame] | 73 | |
Markus Klotzbuecher | b237d35 | 2019-05-15 15:15:52 +0200 | [diff] [blame] | 74 | SIZES = { |
Simon Glass | daa694d | 2021-12-18 14:54:30 -0700 | [diff] [blame] | 75 | 'SZ_1': 0x00000001, 'SZ_2': 0x00000002, |
| 76 | 'SZ_4': 0x00000004, 'SZ_8': 0x00000008, |
| 77 | 'SZ_16': 0x00000010, 'SZ_32': 0x00000020, |
| 78 | 'SZ_64': 0x00000040, 'SZ_128': 0x00000080, |
| 79 | 'SZ_256': 0x00000100, 'SZ_512': 0x00000200, |
| 80 | 'SZ_1K': 0x00000400, 'SZ_2K': 0x00000800, |
| 81 | 'SZ_4K': 0x00001000, 'SZ_8K': 0x00002000, |
| 82 | 'SZ_16K': 0x00004000, 'SZ_32K': 0x00008000, |
| 83 | 'SZ_64K': 0x00010000, 'SZ_128K': 0x00020000, |
| 84 | 'SZ_256K': 0x00040000, 'SZ_512K': 0x00080000, |
| 85 | 'SZ_1M': 0x00100000, 'SZ_2M': 0x00200000, |
| 86 | 'SZ_4M': 0x00400000, 'SZ_8M': 0x00800000, |
| 87 | 'SZ_16M': 0x01000000, 'SZ_32M': 0x02000000, |
| 88 | 'SZ_64M': 0x04000000, 'SZ_128M': 0x08000000, |
| 89 | 'SZ_256M': 0x10000000, 'SZ_512M': 0x20000000, |
| 90 | 'SZ_1G': 0x40000000, 'SZ_2G': 0x80000000, |
| 91 | 'SZ_4G': 0x100000000 |
Markus Klotzbuecher | b237d35 | 2019-05-15 15:15:52 +0200 | [diff] [blame] | 92 | } |
| 93 | |
Simon Glass | b8d11da | 2022-02-08 11:49:45 -0700 | [diff] [blame] | 94 | RE_REMOVE_DEFCONFIG = re.compile(r'(.*)_defconfig') |
| 95 | |
Simon Glass | 65e6203 | 2023-02-01 13:19:12 -0700 | [diff] [blame] | 96 | # CONFIG symbols present in the build system (from Linux) but not actually used |
| 97 | # in U-Boot; KCONFIG symbols |
| 98 | IGNORE_SYMS = ['DEBUG_SECTION_MISMATCH', 'FTRACE_MCOUNT_RECORD', 'GCOV_KERNEL', |
| 99 | 'GCOV_PROFILE_ALL', 'KALLSYMS', 'KASAN', 'MODVERSIONS', 'SHELL', |
| 100 | 'TPL_BUILD', 'VPL_BUILD', 'IS_ENABLED', 'FOO', 'IF_ENABLED_INT', |
| 101 | 'IS_ENABLED_', 'IS_ENABLED_1', 'IS_ENABLED_2', 'IS_ENABLED_3', |
| 102 | 'SPL_', 'TPL_', 'SPL_FOO', 'TPL_FOO', 'TOOLS_FOO', |
| 103 | 'ACME', 'SPL_ACME', 'TPL_ACME', 'TRACE_BRANCH_PROFILING', |
| 104 | 'VAL', '_UNDEFINED', 'SPL_BUILD', ] |
| 105 | |
| 106 | SPL_PREFIXES = ['SPL_', 'TPL_', 'VPL_', 'TOOLS_'] |
| 107 | |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 108 | ### helper functions ### |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 109 | def check_top_directory(): |
| 110 | """Exit if we are not at the top of source directory.""" |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 111 | for fname in 'README', 'Licenses': |
| 112 | if not os.path.exists(fname): |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 113 | sys.exit('Please run at the top of source directory.') |
| 114 | |
Masahiro Yamada | bd63e5b | 2016-05-19 15:51:54 +0900 | [diff] [blame] | 115 | def check_clean_directory(): |
| 116 | """Exit if the source tree is not clean.""" |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 117 | for fname in '.config', 'include/config': |
| 118 | if os.path.exists(fname): |
Masahiro Yamada | bd63e5b | 2016-05-19 15:51:54 +0900 | [diff] [blame] | 119 | sys.exit("source tree is not clean, please run 'make mrproper'") |
| 120 | |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 121 | def get_make_cmd(): |
| 122 | """Get the command name of GNU Make. |
| 123 | |
| 124 | U-Boot needs GNU Make for building, but the command name is not |
| 125 | necessarily "make". (for example, "gmake" on FreeBSD). |
| 126 | Returns the most appropriate command name on your system. |
| 127 | """ |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 128 | with subprocess.Popen([SHOW_GNU_MAKE], stdout=subprocess.PIPE) as proc: |
| 129 | ret = proc.communicate() |
| 130 | if proc.returncode: |
| 131 | sys.exit('GNU Make not found') |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 132 | return ret[0].rstrip() |
| 133 | |
Simon Glass | 25f978c | 2017-06-01 19:38:58 -0600 | [diff] [blame] | 134 | def get_matched_defconfig(line): |
| 135 | """Get the defconfig files that match a pattern |
| 136 | |
| 137 | Args: |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 138 | line (str): Path or filename to match, e.g. 'configs/snow_defconfig' or |
Simon Glass | 25f978c | 2017-06-01 19:38:58 -0600 | [diff] [blame] | 139 | 'k2*_defconfig'. If no directory is provided, 'configs/' is |
| 140 | prepended |
| 141 | |
| 142 | Returns: |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 143 | list of str: a list of matching defconfig files |
Simon Glass | 25f978c | 2017-06-01 19:38:58 -0600 | [diff] [blame] | 144 | """ |
| 145 | dirname = os.path.dirname(line) |
| 146 | if dirname: |
| 147 | pattern = line |
| 148 | else: |
| 149 | pattern = os.path.join('configs', line) |
| 150 | return glob.glob(pattern) + glob.glob(pattern + '_defconfig') |
| 151 | |
Masahiro Yamada | 0dbc9b5 | 2016-10-19 14:39:54 +0900 | [diff] [blame] | 152 | def get_matched_defconfigs(defconfigs_file): |
Simon Glass | ee4e61b | 2017-06-01 19:38:59 -0600 | [diff] [blame] | 153 | """Get all the defconfig files that match the patterns in a file. |
| 154 | |
| 155 | Args: |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 156 | defconfigs_file (str): File containing a list of defconfigs to process, |
| 157 | or '-' to read the list from stdin |
Simon Glass | ee4e61b | 2017-06-01 19:38:59 -0600 | [diff] [blame] | 158 | |
| 159 | Returns: |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 160 | list of str: A list of paths to defconfig files, with no duplicates |
Simon Glass | ee4e61b | 2017-06-01 19:38:59 -0600 | [diff] [blame] | 161 | """ |
Masahiro Yamada | 0dbc9b5 | 2016-10-19 14:39:54 +0900 | [diff] [blame] | 162 | defconfigs = [] |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 163 | with ExitStack() as stack: |
| 164 | if defconfigs_file == '-': |
| 165 | inf = sys.stdin |
| 166 | defconfigs_file = 'stdin' |
| 167 | else: |
| 168 | inf = stack.enter_context(open(defconfigs_file, encoding='utf-8')) |
| 169 | for i, line in enumerate(inf): |
| 170 | line = line.strip() |
| 171 | if not line: |
| 172 | continue # skip blank lines silently |
| 173 | if ' ' in line: |
| 174 | line = line.split(' ')[0] # handle 'git log' input |
| 175 | matched = get_matched_defconfig(line) |
| 176 | if not matched: |
| 177 | print(f"warning: {defconfigs_file}:{i + 1}: no defconfig matched '{line}'", |
| 178 | file=sys.stderr) |
Masahiro Yamada | 0dbc9b5 | 2016-10-19 14:39:54 +0900 | [diff] [blame] | 179 | |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 180 | defconfigs += matched |
Masahiro Yamada | 0dbc9b5 | 2016-10-19 14:39:54 +0900 | [diff] [blame] | 181 | |
| 182 | # use set() to drop multiple matching |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 183 | return [defconfig[len('configs') + 1:] for defconfig in set(defconfigs)] |
Masahiro Yamada | 0dbc9b5 | 2016-10-19 14:39:54 +0900 | [diff] [blame] | 184 | |
Masahiro Yamada | 684c306 | 2016-07-25 19:15:28 +0900 | [diff] [blame] | 185 | def get_all_defconfigs(): |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 186 | """Get all the defconfig files under the configs/ directory. |
| 187 | |
| 188 | Returns: |
| 189 | list of str: List of paths to defconfig files |
| 190 | """ |
Masahiro Yamada | 684c306 | 2016-07-25 19:15:28 +0900 | [diff] [blame] | 191 | defconfigs = [] |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 192 | for (dirpath, _, filenames) in os.walk('configs'): |
Masahiro Yamada | 684c306 | 2016-07-25 19:15:28 +0900 | [diff] [blame] | 193 | dirpath = dirpath[len('configs') + 1:] |
| 194 | for filename in fnmatch.filter(filenames, '*_defconfig'): |
| 195 | defconfigs.append(os.path.join(dirpath, filename)) |
| 196 | |
| 197 | return defconfigs |
| 198 | |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 199 | def color_text(color_enabled, color, string): |
| 200 | """Return colored string.""" |
| 201 | if color_enabled: |
Masahiro Yamada | 1d08556 | 2016-05-19 15:52:02 +0900 | [diff] [blame] | 202 | # LF should not be surrounded by the escape sequence. |
| 203 | # Otherwise, additional whitespace or line-feed might be printed. |
| 204 | return '\n'.join([ '\033[' + color + 'm' + s + '\033[0m' if s else '' |
| 205 | for s in string.split('\n') ]) |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 206 | return string |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 207 | |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 208 | def show_diff(alines, blines, file_path, color_enabled): |
Masahiro Yamada | f2f6981 | 2016-07-25 19:15:25 +0900 | [diff] [blame] | 209 | """Show unidified diff. |
| 210 | |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 211 | Args: |
| 212 | alines (list of str): A list of lines (before) |
| 213 | blines (list of str): A list of lines (after) |
| 214 | file_path (str): Path to the file |
| 215 | color_enabled (bool): Display the diff in color |
Masahiro Yamada | f2f6981 | 2016-07-25 19:15:25 +0900 | [diff] [blame] | 216 | """ |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 217 | diff = difflib.unified_diff(alines, blines, |
Masahiro Yamada | f2f6981 | 2016-07-25 19:15:25 +0900 | [diff] [blame] | 218 | fromfile=os.path.join('a', file_path), |
| 219 | tofile=os.path.join('b', file_path)) |
| 220 | |
| 221 | for line in diff: |
Alper Nebi Yasak | 6c928c6 | 2022-01-29 18:22:08 +0300 | [diff] [blame] | 222 | if line.startswith('-') and not line.startswith('--'): |
| 223 | print(color_text(color_enabled, COLOR_RED, line)) |
| 224 | elif line.startswith('+') and not line.startswith('++'): |
| 225 | print(color_text(color_enabled, COLOR_GREEN, line)) |
Masahiro Yamada | e9ea122 | 2016-07-25 19:15:26 +0900 | [diff] [blame] | 226 | else: |
Alper Nebi Yasak | 6c928c6 | 2022-01-29 18:22:08 +0300 | [diff] [blame] | 227 | print(line) |
Masahiro Yamada | f2f6981 | 2016-07-25 19:15:25 +0900 | [diff] [blame] | 228 | |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 229 | def extend_matched_lines(lines, matched, pre_patterns, post_patterns, |
| 230 | extend_pre, extend_post): |
Masahiro Yamada | 8ba1f5d | 2016-07-25 19:15:24 +0900 | [diff] [blame] | 231 | """Extend matched lines if desired patterns are found before/after already |
| 232 | matched lines. |
| 233 | |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 234 | Args: |
| 235 | lines (list of str): list of lines handled. |
| 236 | matched (list of int): list of line numbers that have been already |
| 237 | matched (will be updated by this function) |
| 238 | pre_patterns (list of re.Pattern): list of regular expression that should |
| 239 | be matched as preamble |
| 240 | post_patterns (list of re.Pattern): list of regular expression that should |
| 241 | be matched as postamble |
| 242 | extend_pre (bool): Add the line number of matched preamble to the matched |
| 243 | list |
| 244 | extend_post (bool): Add the line number of matched postamble to the |
| 245 | matched list |
Masahiro Yamada | 8ba1f5d | 2016-07-25 19:15:24 +0900 | [diff] [blame] | 246 | """ |
| 247 | extended_matched = [] |
| 248 | |
| 249 | j = matched[0] |
| 250 | |
| 251 | for i in matched: |
| 252 | if i == 0 or i < j: |
| 253 | continue |
| 254 | j = i |
| 255 | while j in matched: |
| 256 | j += 1 |
| 257 | if j >= len(lines): |
| 258 | break |
| 259 | |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 260 | for pat in pre_patterns: |
| 261 | if pat.search(lines[i - 1]): |
Masahiro Yamada | 8ba1f5d | 2016-07-25 19:15:24 +0900 | [diff] [blame] | 262 | break |
| 263 | else: |
| 264 | # not matched |
| 265 | continue |
| 266 | |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 267 | for pat in post_patterns: |
| 268 | if pat.search(lines[j]): |
Masahiro Yamada | 8ba1f5d | 2016-07-25 19:15:24 +0900 | [diff] [blame] | 269 | break |
| 270 | else: |
| 271 | # not matched |
| 272 | continue |
| 273 | |
| 274 | if extend_pre: |
| 275 | extended_matched.append(i - 1) |
| 276 | if extend_post: |
| 277 | extended_matched.append(j) |
| 278 | |
| 279 | matched += extended_matched |
| 280 | matched.sort() |
| 281 | |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 282 | def confirm(args, prompt): |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 283 | """Ask the user to confirm something |
| 284 | |
| 285 | Args: |
| 286 | args (Namespace ): program arguments |
| 287 | |
| 288 | Returns: |
| 289 | bool: True to confirm, False to cancel/stop |
| 290 | """ |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 291 | if not args.yes: |
Chris Packham | 85edfc1 | 2017-05-02 21:30:46 +1200 | [diff] [blame] | 292 | while True: |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 293 | choice = input(f'{prompt} [y/n]: ') |
Chris Packham | 85edfc1 | 2017-05-02 21:30:46 +1200 | [diff] [blame] | 294 | choice = choice.lower() |
Simon Glass | 793dca3 | 2019-10-31 07:42:57 -0600 | [diff] [blame] | 295 | print(choice) |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 296 | if choice in ('y', 'n'): |
Chris Packham | 85edfc1 | 2017-05-02 21:30:46 +1200 | [diff] [blame] | 297 | break |
| 298 | |
| 299 | if choice == 'n': |
| 300 | return False |
| 301 | |
| 302 | return True |
| 303 | |
Simon Glass | 2fd85bd | 2021-12-18 14:54:33 -0700 | [diff] [blame] | 304 | def write_file(fname, data): |
| 305 | """Write data to a file |
| 306 | |
| 307 | Args: |
| 308 | fname (str): Filename to write to |
| 309 | data (list of str): Lines to write (with or without trailing newline); |
| 310 | or str to write |
| 311 | """ |
| 312 | with open(fname, 'w', encoding='utf-8') as out: |
| 313 | if isinstance(data, list): |
| 314 | for line in data: |
| 315 | print(line.rstrip('\n'), file=out) |
| 316 | else: |
| 317 | out.write(data) |
| 318 | |
Simon Glass | 37f815c | 2021-12-18 14:54:34 -0700 | [diff] [blame] | 319 | def read_file(fname, as_lines=True, skip_unicode=False): |
| 320 | """Read a file and return the contents |
| 321 | |
| 322 | Args: |
| 323 | fname (str): Filename to read from |
| 324 | as_lines: Return file contents as a list of lines |
| 325 | skip_unicode (bool): True to report unicode errors and continue |
| 326 | |
| 327 | Returns: |
| 328 | iter of str: List of ;ines from the file with newline removed; str if |
| 329 | as_lines is False with newlines intact; or None if a unicode error |
| 330 | occurred |
| 331 | |
| 332 | Raises: |
| 333 | UnicodeDecodeError: Unicode error occurred when reading |
| 334 | """ |
| 335 | with open(fname, encoding='utf-8') as inf: |
| 336 | try: |
| 337 | if as_lines: |
| 338 | return [line.rstrip('\n') for line in inf.readlines()] |
| 339 | else: |
| 340 | return inf.read() |
| 341 | except UnicodeDecodeError as e: |
| 342 | if not skip_unicode: |
Simon Glass | 68a0b71 | 2022-02-11 13:23:22 -0700 | [diff] [blame] | 343 | raise |
Simon Glass | 37f815c | 2021-12-18 14:54:34 -0700 | [diff] [blame] | 344 | print("Failed on file %s': %s" % (fname, e)) |
| 345 | return None |
| 346 | |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 347 | def cleanup_empty_blocks(header_path, args): |
Chris Packham | 4d9dbb1 | 2019-01-30 20:23:16 +1300 | [diff] [blame] | 348 | """Clean up empty conditional blocks |
| 349 | |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 350 | Args: |
| 351 | header_path (str): path to the cleaned file. |
| 352 | args (Namespace): program arguments |
Chris Packham | 4d9dbb1 | 2019-01-30 20:23:16 +1300 | [diff] [blame] | 353 | """ |
| 354 | pattern = re.compile(r'^\s*#\s*if.*$\n^\s*#\s*endif.*$\n*', flags=re.M) |
Simon Glass | 37f815c | 2021-12-18 14:54:34 -0700 | [diff] [blame] | 355 | data = read_file(header_path, as_lines=False, skip_unicode=True) |
| 356 | if data is None: |
| 357 | return |
Chris Packham | 4d9dbb1 | 2019-01-30 20:23:16 +1300 | [diff] [blame] | 358 | |
| 359 | new_data = pattern.sub('\n', data) |
| 360 | |
| 361 | show_diff(data.splitlines(True), new_data.splitlines(True), header_path, |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 362 | args.color) |
Chris Packham | 4d9dbb1 | 2019-01-30 20:23:16 +1300 | [diff] [blame] | 363 | |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 364 | if args.dry_run: |
Chris Packham | 4d9dbb1 | 2019-01-30 20:23:16 +1300 | [diff] [blame] | 365 | return |
| 366 | |
Simon Glass | 37f815c | 2021-12-18 14:54:34 -0700 | [diff] [blame] | 367 | if new_data != data: |
| 368 | write_file(header_path, new_data) |
Chris Packham | 4d9dbb1 | 2019-01-30 20:23:16 +1300 | [diff] [blame] | 369 | |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 370 | def cleanup_one_header(header_path, patterns, args): |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 371 | """Clean regex-matched lines away from a file. |
| 372 | |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 373 | Args: |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 374 | header_path: path to the cleaned file. |
| 375 | patterns: list of regex patterns. Any lines matching to these |
| 376 | patterns are deleted. |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 377 | args (Namespace): program arguments |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 378 | """ |
Simon Glass | 37f815c | 2021-12-18 14:54:34 -0700 | [diff] [blame] | 379 | lines = read_file(header_path, skip_unicode=True) |
| 380 | if lines is None: |
| 381 | return |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 382 | |
| 383 | matched = [] |
| 384 | for i, line in enumerate(lines): |
Alper Nebi Yasak | 6c928c6 | 2022-01-29 18:22:08 +0300 | [diff] [blame] | 385 | if i - 1 in matched and lines[i - 1].endswith('\\'): |
Masahiro Yamada | a3a779f | 2016-07-25 19:15:27 +0900 | [diff] [blame] | 386 | matched.append(i) |
| 387 | continue |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 388 | for pattern in patterns: |
Masahiro Yamada | 8ba1f5d | 2016-07-25 19:15:24 +0900 | [diff] [blame] | 389 | if pattern.search(line): |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 390 | matched.append(i) |
| 391 | break |
| 392 | |
Masahiro Yamada | 8ba1f5d | 2016-07-25 19:15:24 +0900 | [diff] [blame] | 393 | if not matched: |
| 394 | return |
| 395 | |
| 396 | # remove empty #ifdef ... #endif, successive blank lines |
Alper Nebi Yasak | 6c928c6 | 2022-01-29 18:22:08 +0300 | [diff] [blame] | 397 | pattern_if = re.compile(r'#\s*if(def|ndef)?\b') # #if, #ifdef, #ifndef |
| 398 | pattern_elif = re.compile(r'#\s*el(if|se)\b') # #elif, #else |
| 399 | pattern_endif = re.compile(r'#\s*endif\b') # #endif |
Masahiro Yamada | 8ba1f5d | 2016-07-25 19:15:24 +0900 | [diff] [blame] | 400 | pattern_blank = re.compile(r'^\s*$') # empty line |
| 401 | |
| 402 | while True: |
| 403 | old_matched = copy.copy(matched) |
| 404 | extend_matched_lines(lines, matched, [pattern_if], |
| 405 | [pattern_endif], True, True) |
| 406 | extend_matched_lines(lines, matched, [pattern_elif], |
| 407 | [pattern_elif, pattern_endif], True, False) |
| 408 | extend_matched_lines(lines, matched, [pattern_if, pattern_elif], |
| 409 | [pattern_blank], False, True) |
| 410 | extend_matched_lines(lines, matched, [pattern_blank], |
| 411 | [pattern_elif, pattern_endif], True, False) |
| 412 | extend_matched_lines(lines, matched, [pattern_blank], |
| 413 | [pattern_blank], True, False) |
| 414 | if matched == old_matched: |
| 415 | break |
| 416 | |
Masahiro Yamada | f2f6981 | 2016-07-25 19:15:25 +0900 | [diff] [blame] | 417 | tolines = copy.copy(lines) |
| 418 | |
| 419 | for i in reversed(matched): |
| 420 | tolines.pop(i) |
| 421 | |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 422 | show_diff(lines, tolines, header_path, args.color) |
Masahiro Yamada | 8ba1f5d | 2016-07-25 19:15:24 +0900 | [diff] [blame] | 423 | |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 424 | if args.dry_run: |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 425 | return |
| 426 | |
Simon Glass | 2fd85bd | 2021-12-18 14:54:33 -0700 | [diff] [blame] | 427 | write_file(header_path, tolines) |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 428 | |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 429 | def cleanup_headers(configs, args): |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 430 | """Delete config defines from board headers. |
| 431 | |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 432 | Args: |
Masahiro Yamada | b134bc1 | 2016-05-19 15:51:57 +0900 | [diff] [blame] | 433 | configs: A list of CONFIGs to remove. |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 434 | args (Namespace): program arguments |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 435 | """ |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 436 | if not confirm(args, 'Clean up headers?'): |
Chris Packham | 85edfc1 | 2017-05-02 21:30:46 +1200 | [diff] [blame] | 437 | return |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 438 | |
| 439 | patterns = [] |
Masahiro Yamada | b134bc1 | 2016-05-19 15:51:57 +0900 | [diff] [blame] | 440 | for config in configs: |
Alper Nebi Yasak | 6c928c6 | 2022-01-29 18:22:08 +0300 | [diff] [blame] | 441 | patterns.append(re.compile(r'#\s*define\s+%s\b' % config)) |
| 442 | patterns.append(re.compile(r'#\s*undef\s+%s\b' % config)) |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 443 | |
Joe Hershberger | 60727f5 | 2015-05-19 13:21:21 -0500 | [diff] [blame] | 444 | for dir in 'include', 'arch', 'board': |
| 445 | for (dirpath, dirnames, filenames) in os.walk(dir): |
Masahiro Yamada | dc6de50 | 2016-07-25 19:15:22 +0900 | [diff] [blame] | 446 | if dirpath == os.path.join('include', 'generated'): |
| 447 | continue |
Joe Hershberger | 60727f5 | 2015-05-19 13:21:21 -0500 | [diff] [blame] | 448 | for filename in filenames: |
Simon Glass | a38cc17 | 2020-08-11 11:23:34 -0600 | [diff] [blame] | 449 | if not filename.endswith(('~', '.dts', '.dtsi', '.bin', |
Trevor Woerner | dc514d7 | 2021-03-15 12:01:33 -0400 | [diff] [blame] | 450 | '.elf','.aml','.dat')): |
Chris Packham | 4d9dbb1 | 2019-01-30 20:23:16 +1300 | [diff] [blame] | 451 | header_path = os.path.join(dirpath, filename) |
Tom Rini | 02b5670 | 2019-11-10 21:19:37 -0500 | [diff] [blame] | 452 | # This file contains UTF-16 data and no CONFIG symbols |
| 453 | if header_path == 'include/video_font_data.h': |
| 454 | continue |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 455 | cleanup_one_header(header_path, patterns, args) |
| 456 | cleanup_empty_blocks(header_path, args) |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 457 | |
Chris Packham | f90df59 | 2017-05-02 21:30:48 +1200 | [diff] [blame] | 458 | def find_matching(patterns, line): |
| 459 | for pat in patterns: |
| 460 | if pat.search(line): |
| 461 | return True |
| 462 | return False |
| 463 | |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 464 | def cleanup_readme(configs, args): |
Chris Packham | f90df59 | 2017-05-02 21:30:48 +1200 | [diff] [blame] | 465 | """Delete config description in README |
| 466 | |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 467 | Args: |
Chris Packham | f90df59 | 2017-05-02 21:30:48 +1200 | [diff] [blame] | 468 | configs: A list of CONFIGs to remove. |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 469 | args (Namespace): program arguments |
Chris Packham | f90df59 | 2017-05-02 21:30:48 +1200 | [diff] [blame] | 470 | """ |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 471 | if not confirm(args, 'Clean up README?'): |
Chris Packham | f90df59 | 2017-05-02 21:30:48 +1200 | [diff] [blame] | 472 | return |
| 473 | |
| 474 | patterns = [] |
| 475 | for config in configs: |
| 476 | patterns.append(re.compile(r'^\s+%s' % config)) |
| 477 | |
Simon Glass | 37f815c | 2021-12-18 14:54:34 -0700 | [diff] [blame] | 478 | lines = read_file('README') |
Chris Packham | f90df59 | 2017-05-02 21:30:48 +1200 | [diff] [blame] | 479 | |
| 480 | found = False |
| 481 | newlines = [] |
| 482 | for line in lines: |
| 483 | if not found: |
| 484 | found = find_matching(patterns, line) |
| 485 | if found: |
| 486 | continue |
| 487 | |
| 488 | if found and re.search(r'^\s+CONFIG', line): |
| 489 | found = False |
| 490 | |
| 491 | if not found: |
| 492 | newlines.append(line) |
| 493 | |
Simon Glass | 2fd85bd | 2021-12-18 14:54:33 -0700 | [diff] [blame] | 494 | write_file('README', newlines) |
Chris Packham | f90df59 | 2017-05-02 21:30:48 +1200 | [diff] [blame] | 495 | |
Markus Klotzbuecher | b237d35 | 2019-05-15 15:15:52 +0200 | [diff] [blame] | 496 | def try_expand(line): |
| 497 | """If value looks like an expression, try expanding it |
| 498 | Otherwise just return the existing value |
| 499 | """ |
| 500 | if line.find('=') == -1: |
| 501 | return line |
| 502 | |
| 503 | try: |
Markus Klotzbuecher | b3192f4 | 2020-02-12 20:46:44 +0100 | [diff] [blame] | 504 | aeval = asteval.Interpreter( usersyms=SIZES, minimal=True ) |
Markus Klotzbuecher | b237d35 | 2019-05-15 15:15:52 +0200 | [diff] [blame] | 505 | cfg, val = re.split("=", line) |
| 506 | val= val.strip('\"') |
Simon Glass | daa694d | 2021-12-18 14:54:30 -0700 | [diff] [blame] | 507 | if re.search(r'[*+-/]|<<|SZ_+|\(([^\)]+)\)', val): |
Markus Klotzbuecher | b3192f4 | 2020-02-12 20:46:44 +0100 | [diff] [blame] | 508 | newval = hex(aeval(val)) |
Simon Glass | daa694d | 2021-12-18 14:54:30 -0700 | [diff] [blame] | 509 | print('\tExpanded expression %s to %s' % (val, newval)) |
Markus Klotzbuecher | b237d35 | 2019-05-15 15:15:52 +0200 | [diff] [blame] | 510 | return cfg+'='+newval |
| 511 | except: |
Simon Glass | daa694d | 2021-12-18 14:54:30 -0700 | [diff] [blame] | 512 | print('\tFailed to expand expression in %s' % line) |
Markus Klotzbuecher | b237d35 | 2019-05-15 15:15:52 +0200 | [diff] [blame] | 513 | |
| 514 | return line |
| 515 | |
Chris Packham | ca43834 | 2017-05-02 21:30:47 +1200 | [diff] [blame] | 516 | |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 517 | ### classes ### |
Masahiro Yamada | c5e60fd | 2016-05-19 15:51:55 +0900 | [diff] [blame] | 518 | class Progress: |
| 519 | |
| 520 | """Progress Indicator""" |
| 521 | |
| 522 | def __init__(self, total): |
| 523 | """Create a new progress indicator. |
| 524 | |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 525 | Args: |
Masahiro Yamada | c5e60fd | 2016-05-19 15:51:55 +0900 | [diff] [blame] | 526 | total: A number of defconfig files to process. |
| 527 | """ |
| 528 | self.current = 0 |
| 529 | self.total = total |
| 530 | |
| 531 | def inc(self): |
| 532 | """Increment the number of processed defconfig files.""" |
| 533 | |
| 534 | self.current += 1 |
| 535 | |
| 536 | def show(self): |
| 537 | """Display the progress.""" |
Simon Glass | 793dca3 | 2019-10-31 07:42:57 -0600 | [diff] [blame] | 538 | print(' %d defconfigs out of %d\r' % (self.current, self.total), end=' ') |
Masahiro Yamada | c5e60fd | 2016-05-19 15:51:55 +0900 | [diff] [blame] | 539 | sys.stdout.flush() |
| 540 | |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 541 | |
| 542 | class KconfigScanner: |
| 543 | """Kconfig scanner.""" |
| 544 | |
| 545 | def __init__(self): |
| 546 | """Scan all the Kconfig files and create a Config object.""" |
| 547 | # Define environment variables referenced from Kconfig |
| 548 | os.environ['srctree'] = os.getcwd() |
| 549 | os.environ['UBOOTVERSION'] = 'dummy' |
| 550 | os.environ['KCONFIG_OBJDIR'] = '' |
Simon Glass | 65e6203 | 2023-02-01 13:19:12 -0700 | [diff] [blame] | 551 | os.environ['CC'] = 'gcc' |
Tom Rini | 65e05dd | 2019-09-20 17:42:09 -0400 | [diff] [blame] | 552 | self.conf = kconfiglib.Kconfig() |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 553 | |
| 554 | |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 555 | class KconfigParser: |
| 556 | |
| 557 | """A parser of .config and include/autoconf.mk.""" |
| 558 | |
| 559 | re_arch = re.compile(r'CONFIG_SYS_ARCH="(.*)"') |
| 560 | re_cpu = re.compile(r'CONFIG_SYS_CPU="(.*)"') |
| 561 | |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 562 | def __init__(self, configs, args, build_dir): |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 563 | """Create a new parser. |
| 564 | |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 565 | Args: |
Masahiro Yamada | b134bc1 | 2016-05-19 15:51:57 +0900 | [diff] [blame] | 566 | configs: A list of CONFIGs to move. |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 567 | args (Namespace): program arguments |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 568 | build_dir: Build directory. |
| 569 | """ |
Masahiro Yamada | b134bc1 | 2016-05-19 15:51:57 +0900 | [diff] [blame] | 570 | self.configs = configs |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 571 | self.args = args |
Masahiro Yamada | 1f16992 | 2016-05-19 15:52:00 +0900 | [diff] [blame] | 572 | self.dotconfig = os.path.join(build_dir, '.config') |
| 573 | self.autoconf = os.path.join(build_dir, 'include', 'autoconf.mk') |
Masahiro Yamada | 07913d1 | 2016-08-22 22:18:22 +0900 | [diff] [blame] | 574 | self.spl_autoconf = os.path.join(build_dir, 'spl', 'include', |
| 575 | 'autoconf.mk') |
Simon Glass | f3b8e64 | 2017-06-01 19:39:01 -0600 | [diff] [blame] | 576 | self.config_autoconf = os.path.join(build_dir, AUTO_CONF_PATH) |
Masahiro Yamada | 5da4f85 | 2016-05-19 15:52:06 +0900 | [diff] [blame] | 577 | self.defconfig = os.path.join(build_dir, 'defconfig') |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 578 | |
Simon Glass | 6821a74 | 2017-07-10 14:47:47 -0600 | [diff] [blame] | 579 | def get_arch(self): |
| 580 | """Parse .config file and return the architecture. |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 581 | |
| 582 | Returns: |
Simon Glass | 6821a74 | 2017-07-10 14:47:47 -0600 | [diff] [blame] | 583 | Architecture name (e.g. 'arm'). |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 584 | """ |
| 585 | arch = '' |
| 586 | cpu = '' |
Simon Glass | 37f815c | 2021-12-18 14:54:34 -0700 | [diff] [blame] | 587 | for line in read_file(self.dotconfig): |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 588 | m = self.re_arch.match(line) |
| 589 | if m: |
| 590 | arch = m.group(1) |
| 591 | continue |
| 592 | m = self.re_cpu.match(line) |
| 593 | if m: |
| 594 | cpu = m.group(1) |
| 595 | |
Masahiro Yamada | 90ed6cb | 2016-05-19 15:51:53 +0900 | [diff] [blame] | 596 | if not arch: |
| 597 | return None |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 598 | |
| 599 | # fix-up for aarch64 |
| 600 | if arch == 'arm' and cpu == 'armv8': |
| 601 | arch = 'aarch64' |
| 602 | |
Simon Glass | 6821a74 | 2017-07-10 14:47:47 -0600 | [diff] [blame] | 603 | return arch |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 604 | |
Masahiro Yamada | b134bc1 | 2016-05-19 15:51:57 +0900 | [diff] [blame] | 605 | def parse_one_config(self, config, dotconfig_lines, autoconf_lines): |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 606 | """Parse .config, defconfig, include/autoconf.mk for one config. |
| 607 | |
| 608 | This function looks for the config options in the lines from |
| 609 | defconfig, .config, and include/autoconf.mk in order to decide |
| 610 | which action should be taken for this defconfig. |
| 611 | |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 612 | Args: |
Masahiro Yamada | b134bc1 | 2016-05-19 15:51:57 +0900 | [diff] [blame] | 613 | config: CONFIG name to parse. |
Masahiro Yamada | cc00829 | 2016-05-19 15:51:56 +0900 | [diff] [blame] | 614 | dotconfig_lines: lines from the .config file. |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 615 | autoconf_lines: lines from the include/autoconf.mk file. |
| 616 | |
| 617 | Returns: |
| 618 | A tupple of the action for this defconfig and the line |
| 619 | matched for the config. |
| 620 | """ |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 621 | not_set = '# %s is not set' % config |
| 622 | |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 623 | for line in autoconf_lines: |
| 624 | line = line.rstrip() |
| 625 | if line.startswith(config + '='): |
Masahiro Yamada | cc00829 | 2016-05-19 15:51:56 +0900 | [diff] [blame] | 626 | new_val = line |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 627 | break |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 628 | else: |
Masahiro Yamada | cc00829 | 2016-05-19 15:51:56 +0900 | [diff] [blame] | 629 | new_val = not_set |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 630 | |
Markus Klotzbuecher | b237d35 | 2019-05-15 15:15:52 +0200 | [diff] [blame] | 631 | new_val = try_expand(new_val) |
| 632 | |
Masahiro Yamada | 916224c | 2016-08-22 22:18:21 +0900 | [diff] [blame] | 633 | for line in dotconfig_lines: |
| 634 | line = line.rstrip() |
| 635 | if line.startswith(config + '=') or line == not_set: |
| 636 | old_val = line |
| 637 | break |
| 638 | else: |
| 639 | if new_val == not_set: |
| 640 | return (ACTION_NO_ENTRY, config) |
| 641 | else: |
| 642 | return (ACTION_NO_ENTRY_WARN, config) |
| 643 | |
Masahiro Yamada | cc00829 | 2016-05-19 15:51:56 +0900 | [diff] [blame] | 644 | # If this CONFIG is neither bool nor trisate |
| 645 | if old_val[-2:] != '=y' and old_val[-2:] != '=m' and old_val != not_set: |
| 646 | # tools/scripts/define2mk.sed changes '1' to 'y'. |
| 647 | # This is a problem if the CONFIG is int type. |
| 648 | # Check the type in Kconfig and handle it correctly. |
| 649 | if new_val[-2:] == '=y': |
| 650 | new_val = new_val[:-1] + '1' |
| 651 | |
Masahiro Yamada | 5030159 | 2016-06-15 14:33:50 +0900 | [diff] [blame] | 652 | return (ACTION_NO_CHANGE if old_val == new_val else ACTION_MOVE, |
| 653 | new_val) |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 654 | |
Masahiro Yamada | 1d08556 | 2016-05-19 15:52:02 +0900 | [diff] [blame] | 655 | def update_dotconfig(self): |
Masahiro Yamada | 6ff36d2 | 2016-05-19 15:51:50 +0900 | [diff] [blame] | 656 | """Parse files for the config options and update the .config. |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 657 | |
Masahiro Yamada | cc00829 | 2016-05-19 15:51:56 +0900 | [diff] [blame] | 658 | This function parses the generated .config and include/autoconf.mk |
| 659 | searching the target options. |
Masahiro Yamada | 6ff36d2 | 2016-05-19 15:51:50 +0900 | [diff] [blame] | 660 | Move the config option(s) to the .config as needed. |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 661 | |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 662 | Args: |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 663 | defconfig: defconfig name. |
Masahiro Yamada | 522e8dc | 2016-05-19 15:52:01 +0900 | [diff] [blame] | 664 | |
| 665 | Returns: |
Masahiro Yamada | 7fb0bac | 2016-05-19 15:52:04 +0900 | [diff] [blame] | 666 | Return a tuple of (updated flag, log string). |
| 667 | The "updated flag" is True if the .config was updated, False |
| 668 | otherwise. The "log string" shows what happend to the .config. |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 669 | """ |
| 670 | |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 671 | results = [] |
Masahiro Yamada | 7fb0bac | 2016-05-19 15:52:04 +0900 | [diff] [blame] | 672 | updated = False |
Masahiro Yamada | 916224c | 2016-08-22 22:18:21 +0900 | [diff] [blame] | 673 | suspicious = False |
Masahiro Yamada | 07913d1 | 2016-08-22 22:18:22 +0900 | [diff] [blame] | 674 | rm_files = [self.config_autoconf, self.autoconf] |
| 675 | |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 676 | if self.args.spl: |
Masahiro Yamada | 07913d1 | 2016-08-22 22:18:22 +0900 | [diff] [blame] | 677 | if os.path.exists(self.spl_autoconf): |
| 678 | autoconf_path = self.spl_autoconf |
| 679 | rm_files.append(self.spl_autoconf) |
| 680 | else: |
| 681 | for f in rm_files: |
| 682 | os.remove(f) |
| 683 | return (updated, suspicious, |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 684 | color_text(self.args.color, COLOR_BROWN, |
Masahiro Yamada | 07913d1 | 2016-08-22 22:18:22 +0900 | [diff] [blame] | 685 | "SPL is not enabled. Skipped.") + '\n') |
| 686 | else: |
| 687 | autoconf_path = self.autoconf |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 688 | |
Simon Glass | 37f815c | 2021-12-18 14:54:34 -0700 | [diff] [blame] | 689 | dotconfig_lines = read_file(self.dotconfig) |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 690 | |
Simon Glass | 37f815c | 2021-12-18 14:54:34 -0700 | [diff] [blame] | 691 | autoconf_lines = read_file(autoconf_path) |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 692 | |
Masahiro Yamada | b134bc1 | 2016-05-19 15:51:57 +0900 | [diff] [blame] | 693 | for config in self.configs: |
| 694 | result = self.parse_one_config(config, dotconfig_lines, |
Joe Hershberger | 96464ba | 2015-05-19 13:21:17 -0500 | [diff] [blame] | 695 | autoconf_lines) |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 696 | results.append(result) |
| 697 | |
| 698 | log = '' |
| 699 | |
| 700 | for (action, value) in results: |
| 701 | if action == ACTION_MOVE: |
| 702 | actlog = "Move '%s'" % value |
| 703 | log_color = COLOR_LIGHT_GREEN |
Masahiro Yamada | cc00829 | 2016-05-19 15:51:56 +0900 | [diff] [blame] | 704 | elif action == ACTION_NO_ENTRY: |
Simon Glass | daa694d | 2021-12-18 14:54:30 -0700 | [diff] [blame] | 705 | actlog = '%s is not defined in Kconfig. Do nothing.' % value |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 706 | log_color = COLOR_LIGHT_BLUE |
Masahiro Yamada | 916224c | 2016-08-22 22:18:21 +0900 | [diff] [blame] | 707 | elif action == ACTION_NO_ENTRY_WARN: |
Simon Glass | daa694d | 2021-12-18 14:54:30 -0700 | [diff] [blame] | 708 | actlog = '%s is not defined in Kconfig (suspicious). Do nothing.' % value |
Masahiro Yamada | 916224c | 2016-08-22 22:18:21 +0900 | [diff] [blame] | 709 | log_color = COLOR_YELLOW |
| 710 | suspicious = True |
Masahiro Yamada | cc00829 | 2016-05-19 15:51:56 +0900 | [diff] [blame] | 711 | elif action == ACTION_NO_CHANGE: |
| 712 | actlog = "'%s' is the same as the define in Kconfig. Do nothing." \ |
| 713 | % value |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 714 | log_color = COLOR_LIGHT_PURPLE |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 715 | else: |
Simon Glass | daa694d | 2021-12-18 14:54:30 -0700 | [diff] [blame] | 716 | sys.exit('Internal Error. This should not happen.') |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 717 | |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 718 | log += color_text(self.args.color, log_color, actlog) + '\n' |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 719 | |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 720 | with open(self.dotconfig, 'a', encoding='utf-8') as out: |
Masahiro Yamada | e423d17 | 2016-05-19 15:51:49 +0900 | [diff] [blame] | 721 | for (action, value) in results: |
| 722 | if action == ACTION_MOVE: |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 723 | out.write(value + '\n') |
Masahiro Yamada | 7fb0bac | 2016-05-19 15:52:04 +0900 | [diff] [blame] | 724 | updated = True |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 725 | |
Masahiro Yamada | 5da4f85 | 2016-05-19 15:52:06 +0900 | [diff] [blame] | 726 | self.results = results |
Masahiro Yamada | 07913d1 | 2016-08-22 22:18:22 +0900 | [diff] [blame] | 727 | for f in rm_files: |
| 728 | os.remove(f) |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 729 | |
Masahiro Yamada | 916224c | 2016-08-22 22:18:21 +0900 | [diff] [blame] | 730 | return (updated, suspicious, log) |
Masahiro Yamada | 522e8dc | 2016-05-19 15:52:01 +0900 | [diff] [blame] | 731 | |
Masahiro Yamada | 5da4f85 | 2016-05-19 15:52:06 +0900 | [diff] [blame] | 732 | def check_defconfig(self): |
| 733 | """Check the defconfig after savedefconfig |
| 734 | |
| 735 | Returns: |
| 736 | Return additional log if moved CONFIGs were removed again by |
| 737 | 'make savedefconfig'. |
| 738 | """ |
| 739 | |
| 740 | log = '' |
| 741 | |
Simon Glass | 37f815c | 2021-12-18 14:54:34 -0700 | [diff] [blame] | 742 | defconfig_lines = read_file(self.defconfig) |
Masahiro Yamada | 5da4f85 | 2016-05-19 15:52:06 +0900 | [diff] [blame] | 743 | |
| 744 | for (action, value) in self.results: |
| 745 | if action != ACTION_MOVE: |
| 746 | continue |
Alper Nebi Yasak | 6c928c6 | 2022-01-29 18:22:08 +0300 | [diff] [blame] | 747 | if not value in defconfig_lines: |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 748 | log += color_text(self.args.color, COLOR_YELLOW, |
Masahiro Yamada | 5da4f85 | 2016-05-19 15:52:06 +0900 | [diff] [blame] | 749 | "'%s' was removed by savedefconfig.\n" % |
| 750 | value) |
| 751 | |
| 752 | return log |
| 753 | |
Simon Glass | d73fcb1 | 2017-06-01 19:39:02 -0600 | [diff] [blame] | 754 | |
| 755 | class DatabaseThread(threading.Thread): |
| 756 | """This thread processes results from Slot threads. |
| 757 | |
| 758 | It collects the data in the master config directary. There is only one |
| 759 | result thread, and this helps to serialise the build output. |
| 760 | """ |
| 761 | def __init__(self, config_db, db_queue): |
| 762 | """Set up a new result thread |
| 763 | |
| 764 | Args: |
| 765 | builder: Builder which will be sent each result |
| 766 | """ |
| 767 | threading.Thread.__init__(self) |
| 768 | self.config_db = config_db |
| 769 | self.db_queue= db_queue |
| 770 | |
| 771 | def run(self): |
| 772 | """Called to start up the result thread. |
| 773 | |
| 774 | We collect the next result job and pass it on to the build. |
| 775 | """ |
| 776 | while True: |
| 777 | defconfig, configs = self.db_queue.get() |
| 778 | self.config_db[defconfig] = configs |
| 779 | self.db_queue.task_done() |
| 780 | |
| 781 | |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 782 | class Slot: |
| 783 | |
| 784 | """A slot to store a subprocess. |
| 785 | |
| 786 | Each instance of this class handles one subprocess. |
| 787 | This class is useful to control multiple threads |
| 788 | for faster processing. |
| 789 | """ |
| 790 | |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 791 | def __init__(self, toolchains, configs, args, progress, devnull, |
Simon Glass | 6821a74 | 2017-07-10 14:47:47 -0600 | [diff] [blame] | 792 | make_cmd, reference_src_dir, db_queue): |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 793 | """Create a new process slot. |
| 794 | |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 795 | Args: |
Simon Glass | 6821a74 | 2017-07-10 14:47:47 -0600 | [diff] [blame] | 796 | toolchains: Toolchains object containing toolchains. |
Masahiro Yamada | b134bc1 | 2016-05-19 15:51:57 +0900 | [diff] [blame] | 797 | configs: A list of CONFIGs to move. |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 798 | args: Program arguments |
Masahiro Yamada | c5e60fd | 2016-05-19 15:51:55 +0900 | [diff] [blame] | 799 | progress: A progress indicator. |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 800 | devnull: A file object of '/dev/null'. |
| 801 | make_cmd: command name of GNU Make. |
Joe Hershberger | 6b96c1a | 2016-06-10 14:53:32 -0500 | [diff] [blame] | 802 | reference_src_dir: Determine the true starting config state from this |
| 803 | source tree. |
Simon Glass | d73fcb1 | 2017-06-01 19:39:02 -0600 | [diff] [blame] | 804 | db_queue: output queue to write config info for the database |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 805 | """ |
Simon Glass | 6821a74 | 2017-07-10 14:47:47 -0600 | [diff] [blame] | 806 | self.toolchains = toolchains |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 807 | self.args = args |
Masahiro Yamada | c5e60fd | 2016-05-19 15:51:55 +0900 | [diff] [blame] | 808 | self.progress = progress |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 809 | self.build_dir = tempfile.mkdtemp() |
| 810 | self.devnull = devnull |
| 811 | self.make_cmd = (make_cmd, 'O=' + self.build_dir) |
Joe Hershberger | 6b96c1a | 2016-06-10 14:53:32 -0500 | [diff] [blame] | 812 | self.reference_src_dir = reference_src_dir |
Simon Glass | d73fcb1 | 2017-06-01 19:39:02 -0600 | [diff] [blame] | 813 | self.db_queue = db_queue |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 814 | self.parser = KconfigParser(configs, args, self.build_dir) |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 815 | self.state = STATE_IDLE |
Masahiro Yamada | 09c6c06 | 2016-08-22 22:18:20 +0900 | [diff] [blame] | 816 | self.failed_boards = set() |
| 817 | self.suspicious_boards = set() |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 818 | |
| 819 | def __del__(self): |
| 820 | """Delete the working directory |
| 821 | |
| 822 | This function makes sure the temporary directory is cleaned away |
| 823 | even if Python suddenly dies due to error. It should be done in here |
Joe Hershberger | f2dae75 | 2016-06-10 14:53:29 -0500 | [diff] [blame] | 824 | because it is guaranteed the destructor is always invoked when the |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 825 | instance of the class gets unreferenced. |
| 826 | |
| 827 | If the subprocess is still running, wait until it finishes. |
| 828 | """ |
| 829 | if self.state != STATE_IDLE: |
| 830 | while self.ps.poll() == None: |
| 831 | pass |
| 832 | shutil.rmtree(self.build_dir) |
| 833 | |
Masahiro Yamada | c5e60fd | 2016-05-19 15:51:55 +0900 | [diff] [blame] | 834 | def add(self, defconfig): |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 835 | """Assign a new subprocess for defconfig and add it to the slot. |
| 836 | |
| 837 | If the slot is vacant, create a new subprocess for processing the |
| 838 | given defconfig and add it to the slot. Just returns False if |
| 839 | the slot is occupied (i.e. the current subprocess is still running). |
| 840 | |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 841 | Args: |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 842 | defconfig: defconfig name. |
| 843 | |
| 844 | Returns: |
| 845 | Return True on success or False on failure |
| 846 | """ |
| 847 | if self.state != STATE_IDLE: |
| 848 | return False |
Masahiro Yamada | e307fa9 | 2016-06-08 11:47:37 +0900 | [diff] [blame] | 849 | |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 850 | self.defconfig = defconfig |
Masahiro Yamada | 1d08556 | 2016-05-19 15:52:02 +0900 | [diff] [blame] | 851 | self.log = '' |
Masahiro Yamada | f432c33 | 2016-06-15 14:33:52 +0900 | [diff] [blame] | 852 | self.current_src_dir = self.reference_src_dir |
Masahiro Yamada | e307fa9 | 2016-06-08 11:47:37 +0900 | [diff] [blame] | 853 | self.do_defconfig() |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 854 | return True |
| 855 | |
| 856 | def poll(self): |
| 857 | """Check the status of the subprocess and handle it as needed. |
| 858 | |
| 859 | Returns True if the slot is vacant (i.e. in idle state). |
| 860 | If the configuration is successfully finished, assign a new |
| 861 | subprocess to build include/autoconf.mk. |
| 862 | If include/autoconf.mk is generated, invoke the parser to |
Masahiro Yamada | 7fb0bac | 2016-05-19 15:52:04 +0900 | [diff] [blame] | 863 | parse the .config and the include/autoconf.mk, moving |
| 864 | config options to the .config as needed. |
| 865 | If the .config was updated, run "make savedefconfig" to sync |
| 866 | it, update the original defconfig, and then set the slot back |
| 867 | to the idle state. |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 868 | |
| 869 | Returns: |
| 870 | Return True if the subprocess is terminated, False otherwise |
| 871 | """ |
| 872 | if self.state == STATE_IDLE: |
| 873 | return True |
| 874 | |
| 875 | if self.ps.poll() == None: |
| 876 | return False |
| 877 | |
| 878 | if self.ps.poll() != 0: |
Masahiro Yamada | e307fa9 | 2016-06-08 11:47:37 +0900 | [diff] [blame] | 879 | self.handle_error() |
| 880 | elif self.state == STATE_DEFCONFIG: |
Masahiro Yamada | f432c33 | 2016-06-15 14:33:52 +0900 | [diff] [blame] | 881 | if self.reference_src_dir and not self.current_src_dir: |
Joe Hershberger | 6b96c1a | 2016-06-10 14:53:32 -0500 | [diff] [blame] | 882 | self.do_savedefconfig() |
| 883 | else: |
| 884 | self.do_autoconf() |
Masahiro Yamada | e307fa9 | 2016-06-08 11:47:37 +0900 | [diff] [blame] | 885 | elif self.state == STATE_AUTOCONF: |
Masahiro Yamada | f432c33 | 2016-06-15 14:33:52 +0900 | [diff] [blame] | 886 | if self.current_src_dir: |
| 887 | self.current_src_dir = None |
Joe Hershberger | 6b96c1a | 2016-06-10 14:53:32 -0500 | [diff] [blame] | 888 | self.do_defconfig() |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 889 | elif self.args.build_db: |
Simon Glass | d73fcb1 | 2017-06-01 19:39:02 -0600 | [diff] [blame] | 890 | self.do_build_db() |
Joe Hershberger | 6b96c1a | 2016-06-10 14:53:32 -0500 | [diff] [blame] | 891 | else: |
| 892 | self.do_savedefconfig() |
Masahiro Yamada | e307fa9 | 2016-06-08 11:47:37 +0900 | [diff] [blame] | 893 | elif self.state == STATE_SAVEDEFCONFIG: |
| 894 | self.update_defconfig() |
| 895 | else: |
Simon Glass | daa694d | 2021-12-18 14:54:30 -0700 | [diff] [blame] | 896 | sys.exit('Internal Error. This should not happen.') |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 897 | |
Masahiro Yamada | e307fa9 | 2016-06-08 11:47:37 +0900 | [diff] [blame] | 898 | return True if self.state == STATE_IDLE else False |
Joe Hershberger | 96464ba | 2015-05-19 13:21:17 -0500 | [diff] [blame] | 899 | |
Masahiro Yamada | e307fa9 | 2016-06-08 11:47:37 +0900 | [diff] [blame] | 900 | def handle_error(self): |
| 901 | """Handle error cases.""" |
Masahiro Yamada | 8513dc0 | 2016-05-19 15:52:08 +0900 | [diff] [blame] | 902 | |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 903 | self.log += color_text(self.args.color, COLOR_LIGHT_RED, |
Simon Glass | daa694d | 2021-12-18 14:54:30 -0700 | [diff] [blame] | 904 | 'Failed to process.\n') |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 905 | if self.args.verbose: |
| 906 | self.log += color_text(self.args.color, COLOR_LIGHT_CYAN, |
Markus Klotzbuecher | 4f5c5e9 | 2020-02-12 20:46:45 +0100 | [diff] [blame] | 907 | self.ps.stderr.read().decode()) |
Masahiro Yamada | e307fa9 | 2016-06-08 11:47:37 +0900 | [diff] [blame] | 908 | self.finish(False) |
Joe Hershberger | 96464ba | 2015-05-19 13:21:17 -0500 | [diff] [blame] | 909 | |
Masahiro Yamada | e307fa9 | 2016-06-08 11:47:37 +0900 | [diff] [blame] | 910 | def do_defconfig(self): |
| 911 | """Run 'make <board>_defconfig' to create the .config file.""" |
Masahiro Yamada | c8e1b10 | 2016-05-19 15:52:07 +0900 | [diff] [blame] | 912 | |
Masahiro Yamada | e307fa9 | 2016-06-08 11:47:37 +0900 | [diff] [blame] | 913 | cmd = list(self.make_cmd) |
| 914 | cmd.append(self.defconfig) |
| 915 | self.ps = subprocess.Popen(cmd, stdout=self.devnull, |
Masahiro Yamada | f432c33 | 2016-06-15 14:33:52 +0900 | [diff] [blame] | 916 | stderr=subprocess.PIPE, |
| 917 | cwd=self.current_src_dir) |
Masahiro Yamada | e307fa9 | 2016-06-08 11:47:37 +0900 | [diff] [blame] | 918 | self.state = STATE_DEFCONFIG |
Masahiro Yamada | c8e1b10 | 2016-05-19 15:52:07 +0900 | [diff] [blame] | 919 | |
Masahiro Yamada | e307fa9 | 2016-06-08 11:47:37 +0900 | [diff] [blame] | 920 | def do_autoconf(self): |
Simon Glass | f3b8e64 | 2017-06-01 19:39:01 -0600 | [diff] [blame] | 921 | """Run 'make AUTO_CONF_PATH'.""" |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 922 | |
Simon Glass | 6821a74 | 2017-07-10 14:47:47 -0600 | [diff] [blame] | 923 | arch = self.parser.get_arch() |
| 924 | try: |
| 925 | toolchain = self.toolchains.Select(arch) |
| 926 | except ValueError: |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 927 | self.log += color_text(self.args.color, COLOR_YELLOW, |
Chris Packham | ce3ba45 | 2017-08-27 20:00:51 +1200 | [diff] [blame] | 928 | "Tool chain for '%s' is missing. Do nothing.\n" % arch) |
Masahiro Yamada | 4efef99 | 2016-05-19 15:52:03 +0900 | [diff] [blame] | 929 | self.finish(False) |
Masahiro Yamada | e307fa9 | 2016-06-08 11:47:37 +0900 | [diff] [blame] | 930 | return |
Simon Glass | 793dca3 | 2019-10-31 07:42:57 -0600 | [diff] [blame] | 931 | env = toolchain.MakeEnvironment(False) |
Masahiro Yamada | 90ed6cb | 2016-05-19 15:51:53 +0900 | [diff] [blame] | 932 | |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 933 | cmd = list(self.make_cmd) |
Joe Hershberger | 7740f65 | 2015-05-19 13:21:18 -0500 | [diff] [blame] | 934 | cmd.append('KCONFIG_IGNORE_DUPLICATES=1') |
Simon Glass | f3b8e64 | 2017-06-01 19:39:01 -0600 | [diff] [blame] | 935 | cmd.append(AUTO_CONF_PATH) |
Simon Glass | 6821a74 | 2017-07-10 14:47:47 -0600 | [diff] [blame] | 936 | self.ps = subprocess.Popen(cmd, stdout=self.devnull, env=env, |
Masahiro Yamada | f432c33 | 2016-06-15 14:33:52 +0900 | [diff] [blame] | 937 | stderr=subprocess.PIPE, |
| 938 | cwd=self.current_src_dir) |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 939 | self.state = STATE_AUTOCONF |
Masahiro Yamada | e307fa9 | 2016-06-08 11:47:37 +0900 | [diff] [blame] | 940 | |
Simon Glass | d73fcb1 | 2017-06-01 19:39:02 -0600 | [diff] [blame] | 941 | def do_build_db(self): |
| 942 | """Add the board to the database""" |
| 943 | configs = {} |
Simon Glass | 37f815c | 2021-12-18 14:54:34 -0700 | [diff] [blame] | 944 | for line in read_file(os.path.join(self.build_dir, AUTO_CONF_PATH)): |
| 945 | if line.startswith('CONFIG'): |
| 946 | config, value = line.split('=', 1) |
| 947 | configs[config] = value.rstrip() |
Simon Glass | d73fcb1 | 2017-06-01 19:39:02 -0600 | [diff] [blame] | 948 | self.db_queue.put([self.defconfig, configs]) |
| 949 | self.finish(True) |
| 950 | |
Masahiro Yamada | e307fa9 | 2016-06-08 11:47:37 +0900 | [diff] [blame] | 951 | def do_savedefconfig(self): |
| 952 | """Update the .config and run 'make savedefconfig'.""" |
| 953 | |
Masahiro Yamada | 916224c | 2016-08-22 22:18:21 +0900 | [diff] [blame] | 954 | (updated, suspicious, log) = self.parser.update_dotconfig() |
| 955 | if suspicious: |
| 956 | self.suspicious_boards.add(self.defconfig) |
Masahiro Yamada | e307fa9 | 2016-06-08 11:47:37 +0900 | [diff] [blame] | 957 | self.log += log |
| 958 | |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 959 | if not self.args.force_sync and not updated: |
Masahiro Yamada | e307fa9 | 2016-06-08 11:47:37 +0900 | [diff] [blame] | 960 | self.finish(True) |
| 961 | return |
| 962 | if updated: |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 963 | self.log += color_text(self.args.color, COLOR_LIGHT_GREEN, |
Simon Glass | daa694d | 2021-12-18 14:54:30 -0700 | [diff] [blame] | 964 | 'Syncing by savedefconfig...\n') |
Masahiro Yamada | e307fa9 | 2016-06-08 11:47:37 +0900 | [diff] [blame] | 965 | else: |
Simon Glass | daa694d | 2021-12-18 14:54:30 -0700 | [diff] [blame] | 966 | self.log += 'Syncing by savedefconfig (forced by option)...\n' |
Masahiro Yamada | e307fa9 | 2016-06-08 11:47:37 +0900 | [diff] [blame] | 967 | |
| 968 | cmd = list(self.make_cmd) |
| 969 | cmd.append('savedefconfig') |
| 970 | self.ps = subprocess.Popen(cmd, stdout=self.devnull, |
| 971 | stderr=subprocess.PIPE) |
| 972 | self.state = STATE_SAVEDEFCONFIG |
| 973 | |
| 974 | def update_defconfig(self): |
| 975 | """Update the input defconfig and go back to the idle state.""" |
| 976 | |
Masahiro Yamada | fc2661e | 2016-06-15 14:33:54 +0900 | [diff] [blame] | 977 | log = self.parser.check_defconfig() |
| 978 | if log: |
Masahiro Yamada | 09c6c06 | 2016-08-22 22:18:20 +0900 | [diff] [blame] | 979 | self.suspicious_boards.add(self.defconfig) |
Masahiro Yamada | fc2661e | 2016-06-15 14:33:54 +0900 | [diff] [blame] | 980 | self.log += log |
Masahiro Yamada | e307fa9 | 2016-06-08 11:47:37 +0900 | [diff] [blame] | 981 | orig_defconfig = os.path.join('configs', self.defconfig) |
| 982 | new_defconfig = os.path.join(self.build_dir, 'defconfig') |
| 983 | updated = not filecmp.cmp(orig_defconfig, new_defconfig) |
| 984 | |
| 985 | if updated: |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 986 | self.log += color_text(self.args.color, COLOR_LIGHT_BLUE, |
Simon Glass | daa694d | 2021-12-18 14:54:30 -0700 | [diff] [blame] | 987 | 'defconfig was updated.\n') |
Masahiro Yamada | e307fa9 | 2016-06-08 11:47:37 +0900 | [diff] [blame] | 988 | |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 989 | if not self.args.dry_run and updated: |
Masahiro Yamada | e307fa9 | 2016-06-08 11:47:37 +0900 | [diff] [blame] | 990 | shutil.move(new_defconfig, orig_defconfig) |
| 991 | self.finish(True) |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 992 | |
Masahiro Yamada | 4efef99 | 2016-05-19 15:52:03 +0900 | [diff] [blame] | 993 | def finish(self, success): |
| 994 | """Display log along with progress and go to the idle state. |
Masahiro Yamada | 1d08556 | 2016-05-19 15:52:02 +0900 | [diff] [blame] | 995 | |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 996 | Args: |
Masahiro Yamada | 4efef99 | 2016-05-19 15:52:03 +0900 | [diff] [blame] | 997 | success: Should be True when the defconfig was processed |
| 998 | successfully, or False when it fails. |
Masahiro Yamada | 1d08556 | 2016-05-19 15:52:02 +0900 | [diff] [blame] | 999 | """ |
| 1000 | # output at least 30 characters to hide the "* defconfigs out of *". |
| 1001 | log = self.defconfig.ljust(30) + '\n' |
| 1002 | |
| 1003 | log += '\n'.join([ ' ' + s for s in self.log.split('\n') ]) |
| 1004 | # Some threads are running in parallel. |
| 1005 | # Print log atomically to not mix up logs from different threads. |
Simon Glass | 793dca3 | 2019-10-31 07:42:57 -0600 | [diff] [blame] | 1006 | print(log, file=(sys.stdout if success else sys.stderr)) |
Masahiro Yamada | 4efef99 | 2016-05-19 15:52:03 +0900 | [diff] [blame] | 1007 | |
| 1008 | if not success: |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 1009 | if self.args.exit_on_error: |
Simon Glass | daa694d | 2021-12-18 14:54:30 -0700 | [diff] [blame] | 1010 | sys.exit('Exit on error.') |
Masahiro Yamada | 4efef99 | 2016-05-19 15:52:03 +0900 | [diff] [blame] | 1011 | # If --exit-on-error flag is not set, skip this board and continue. |
| 1012 | # Record the failed board. |
Masahiro Yamada | 09c6c06 | 2016-08-22 22:18:20 +0900 | [diff] [blame] | 1013 | self.failed_boards.add(self.defconfig) |
Masahiro Yamada | 4efef99 | 2016-05-19 15:52:03 +0900 | [diff] [blame] | 1014 | |
Masahiro Yamada | 1d08556 | 2016-05-19 15:52:02 +0900 | [diff] [blame] | 1015 | self.progress.inc() |
| 1016 | self.progress.show() |
Masahiro Yamada | 4efef99 | 2016-05-19 15:52:03 +0900 | [diff] [blame] | 1017 | self.state = STATE_IDLE |
Masahiro Yamada | 1d08556 | 2016-05-19 15:52:02 +0900 | [diff] [blame] | 1018 | |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 1019 | def get_failed_boards(self): |
Masahiro Yamada | 09c6c06 | 2016-08-22 22:18:20 +0900 | [diff] [blame] | 1020 | """Returns a set of failed boards (defconfigs) in this slot. |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 1021 | """ |
| 1022 | return self.failed_boards |
| 1023 | |
Masahiro Yamada | fc2661e | 2016-06-15 14:33:54 +0900 | [diff] [blame] | 1024 | def get_suspicious_boards(self): |
Masahiro Yamada | 09c6c06 | 2016-08-22 22:18:20 +0900 | [diff] [blame] | 1025 | """Returns a set of boards (defconfigs) with possible misconversion. |
Masahiro Yamada | fc2661e | 2016-06-15 14:33:54 +0900 | [diff] [blame] | 1026 | """ |
Masahiro Yamada | 916224c | 2016-08-22 22:18:21 +0900 | [diff] [blame] | 1027 | return self.suspicious_boards - self.failed_boards |
Masahiro Yamada | fc2661e | 2016-06-15 14:33:54 +0900 | [diff] [blame] | 1028 | |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 1029 | class Slots: |
| 1030 | |
| 1031 | """Controller of the array of subprocess slots.""" |
| 1032 | |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 1033 | def __init__(self, toolchains, configs, args, progress, |
Simon Glass | 6821a74 | 2017-07-10 14:47:47 -0600 | [diff] [blame] | 1034 | reference_src_dir, db_queue): |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 1035 | """Create a new slots controller. |
| 1036 | |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 1037 | Args: |
Simon Glass | 6821a74 | 2017-07-10 14:47:47 -0600 | [diff] [blame] | 1038 | toolchains: Toolchains object containing toolchains. |
Masahiro Yamada | b134bc1 | 2016-05-19 15:51:57 +0900 | [diff] [blame] | 1039 | configs: A list of CONFIGs to move. |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 1040 | args: Program arguments |
Masahiro Yamada | c5e60fd | 2016-05-19 15:51:55 +0900 | [diff] [blame] | 1041 | progress: A progress indicator. |
Joe Hershberger | 6b96c1a | 2016-06-10 14:53:32 -0500 | [diff] [blame] | 1042 | reference_src_dir: Determine the true starting config state from this |
| 1043 | source tree. |
Simon Glass | d73fcb1 | 2017-06-01 19:39:02 -0600 | [diff] [blame] | 1044 | db_queue: output queue to write config info for the database |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 1045 | """ |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 1046 | self.args = args |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 1047 | self.slots = [] |
Simon Glass | 478920d | 2021-12-18 14:54:32 -0700 | [diff] [blame] | 1048 | devnull = subprocess.DEVNULL |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 1049 | make_cmd = get_make_cmd() |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 1050 | for i in range(args.jobs): |
| 1051 | self.slots.append(Slot(toolchains, configs, args, progress, |
Simon Glass | 6821a74 | 2017-07-10 14:47:47 -0600 | [diff] [blame] | 1052 | devnull, make_cmd, reference_src_dir, |
| 1053 | db_queue)) |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 1054 | |
Masahiro Yamada | c5e60fd | 2016-05-19 15:51:55 +0900 | [diff] [blame] | 1055 | def add(self, defconfig): |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 1056 | """Add a new subprocess if a vacant slot is found. |
| 1057 | |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 1058 | Args: |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 1059 | defconfig: defconfig name to be put into. |
| 1060 | |
| 1061 | Returns: |
| 1062 | Return True on success or False on failure |
| 1063 | """ |
| 1064 | for slot in self.slots: |
Masahiro Yamada | c5e60fd | 2016-05-19 15:51:55 +0900 | [diff] [blame] | 1065 | if slot.add(defconfig): |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 1066 | return True |
| 1067 | return False |
| 1068 | |
| 1069 | def available(self): |
| 1070 | """Check if there is a vacant slot. |
| 1071 | |
| 1072 | Returns: |
| 1073 | Return True if at lease one vacant slot is found, False otherwise. |
| 1074 | """ |
| 1075 | for slot in self.slots: |
| 1076 | if slot.poll(): |
| 1077 | return True |
| 1078 | return False |
| 1079 | |
| 1080 | def empty(self): |
| 1081 | """Check if all slots are vacant. |
| 1082 | |
| 1083 | Returns: |
| 1084 | Return True if all the slots are vacant, False otherwise. |
| 1085 | """ |
| 1086 | ret = True |
| 1087 | for slot in self.slots: |
| 1088 | if not slot.poll(): |
| 1089 | ret = False |
| 1090 | return ret |
| 1091 | |
| 1092 | def show_failed_boards(self): |
| 1093 | """Display all of the failed boards (defconfigs).""" |
Masahiro Yamada | 09c6c06 | 2016-08-22 22:18:20 +0900 | [diff] [blame] | 1094 | boards = set() |
Masahiro Yamada | 96dccd9 | 2016-06-15 14:33:53 +0900 | [diff] [blame] | 1095 | output_file = 'moveconfig.failed' |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 1096 | |
| 1097 | for slot in self.slots: |
Masahiro Yamada | 09c6c06 | 2016-08-22 22:18:20 +0900 | [diff] [blame] | 1098 | boards |= slot.get_failed_boards() |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 1099 | |
Masahiro Yamada | 96dccd9 | 2016-06-15 14:33:53 +0900 | [diff] [blame] | 1100 | if boards: |
| 1101 | boards = '\n'.join(boards) + '\n' |
Simon Glass | daa694d | 2021-12-18 14:54:30 -0700 | [diff] [blame] | 1102 | msg = 'The following boards were not processed due to error:\n' |
Masahiro Yamada | 96dccd9 | 2016-06-15 14:33:53 +0900 | [diff] [blame] | 1103 | msg += boards |
Simon Glass | daa694d | 2021-12-18 14:54:30 -0700 | [diff] [blame] | 1104 | msg += '(the list has been saved in %s)\n' % output_file |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 1105 | print(color_text(self.args.color, COLOR_LIGHT_RED, |
Simon Glass | 793dca3 | 2019-10-31 07:42:57 -0600 | [diff] [blame] | 1106 | msg), file=sys.stderr) |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 1107 | |
Simon Glass | 2fd85bd | 2021-12-18 14:54:33 -0700 | [diff] [blame] | 1108 | write_file(output_file, boards) |
Joe Hershberger | 2559cd8 | 2015-05-19 13:21:22 -0500 | [diff] [blame] | 1109 | |
Masahiro Yamada | fc2661e | 2016-06-15 14:33:54 +0900 | [diff] [blame] | 1110 | def show_suspicious_boards(self): |
| 1111 | """Display all boards (defconfigs) with possible misconversion.""" |
Masahiro Yamada | 09c6c06 | 2016-08-22 22:18:20 +0900 | [diff] [blame] | 1112 | boards = set() |
Masahiro Yamada | fc2661e | 2016-06-15 14:33:54 +0900 | [diff] [blame] | 1113 | output_file = 'moveconfig.suspicious' |
| 1114 | |
| 1115 | for slot in self.slots: |
Masahiro Yamada | 09c6c06 | 2016-08-22 22:18:20 +0900 | [diff] [blame] | 1116 | boards |= slot.get_suspicious_boards() |
Masahiro Yamada | fc2661e | 2016-06-15 14:33:54 +0900 | [diff] [blame] | 1117 | |
| 1118 | if boards: |
| 1119 | boards = '\n'.join(boards) + '\n' |
Simon Glass | daa694d | 2021-12-18 14:54:30 -0700 | [diff] [blame] | 1120 | msg = 'The following boards might have been converted incorrectly.\n' |
| 1121 | msg += 'It is highly recommended to check them manually:\n' |
Masahiro Yamada | fc2661e | 2016-06-15 14:33:54 +0900 | [diff] [blame] | 1122 | msg += boards |
Simon Glass | daa694d | 2021-12-18 14:54:30 -0700 | [diff] [blame] | 1123 | msg += '(the list has been saved in %s)\n' % output_file |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 1124 | print(color_text(self.args.color, COLOR_YELLOW, |
Simon Glass | 793dca3 | 2019-10-31 07:42:57 -0600 | [diff] [blame] | 1125 | msg), file=sys.stderr) |
Masahiro Yamada | fc2661e | 2016-06-15 14:33:54 +0900 | [diff] [blame] | 1126 | |
Simon Glass | 2fd85bd | 2021-12-18 14:54:33 -0700 | [diff] [blame] | 1127 | write_file(output_file, boards) |
Masahiro Yamada | fc2661e | 2016-06-15 14:33:54 +0900 | [diff] [blame] | 1128 | |
Masahiro Yamada | 5cc42a5 | 2016-06-15 14:33:51 +0900 | [diff] [blame] | 1129 | class ReferenceSource: |
| 1130 | |
| 1131 | """Reference source against which original configs should be parsed.""" |
| 1132 | |
| 1133 | def __init__(self, commit): |
| 1134 | """Create a reference source directory based on a specified commit. |
| 1135 | |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 1136 | Args: |
Masahiro Yamada | 5cc42a5 | 2016-06-15 14:33:51 +0900 | [diff] [blame] | 1137 | commit: commit to git-clone |
| 1138 | """ |
| 1139 | self.src_dir = tempfile.mkdtemp() |
Simon Glass | daa694d | 2021-12-18 14:54:30 -0700 | [diff] [blame] | 1140 | print('Cloning git repo to a separate work directory...') |
Masahiro Yamada | 5cc42a5 | 2016-06-15 14:33:51 +0900 | [diff] [blame] | 1141 | subprocess.check_output(['git', 'clone', os.getcwd(), '.'], |
| 1142 | cwd=self.src_dir) |
Simon Glass | 793dca3 | 2019-10-31 07:42:57 -0600 | [diff] [blame] | 1143 | print("Checkout '%s' to build the original autoconf.mk." % \ |
| 1144 | subprocess.check_output(['git', 'rev-parse', '--short', commit]).strip()) |
Masahiro Yamada | 5cc42a5 | 2016-06-15 14:33:51 +0900 | [diff] [blame] | 1145 | subprocess.check_output(['git', 'checkout', commit], |
| 1146 | stderr=subprocess.STDOUT, cwd=self.src_dir) |
Joe Hershberger | 6b96c1a | 2016-06-10 14:53:32 -0500 | [diff] [blame] | 1147 | |
| 1148 | def __del__(self): |
Masahiro Yamada | 5cc42a5 | 2016-06-15 14:33:51 +0900 | [diff] [blame] | 1149 | """Delete the reference source directory |
Joe Hershberger | 6b96c1a | 2016-06-10 14:53:32 -0500 | [diff] [blame] | 1150 | |
| 1151 | This function makes sure the temporary directory is cleaned away |
| 1152 | even if Python suddenly dies due to error. It should be done in here |
| 1153 | because it is guaranteed the destructor is always invoked when the |
| 1154 | instance of the class gets unreferenced. |
| 1155 | """ |
Masahiro Yamada | 5cc42a5 | 2016-06-15 14:33:51 +0900 | [diff] [blame] | 1156 | shutil.rmtree(self.src_dir) |
Joe Hershberger | 6b96c1a | 2016-06-10 14:53:32 -0500 | [diff] [blame] | 1157 | |
Masahiro Yamada | 5cc42a5 | 2016-06-15 14:33:51 +0900 | [diff] [blame] | 1158 | def get_dir(self): |
| 1159 | """Return the absolute path to the reference source directory.""" |
| 1160 | |
| 1161 | return self.src_dir |
Joe Hershberger | 6b96c1a | 2016-06-10 14:53:32 -0500 | [diff] [blame] | 1162 | |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 1163 | def move_config(toolchains, configs, args, db_queue): |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 1164 | """Move config options to defconfig files. |
| 1165 | |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 1166 | Args: |
Masahiro Yamada | b134bc1 | 2016-05-19 15:51:57 +0900 | [diff] [blame] | 1167 | configs: A list of CONFIGs to move. |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 1168 | args: Program arguments |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 1169 | """ |
Masahiro Yamada | b134bc1 | 2016-05-19 15:51:57 +0900 | [diff] [blame] | 1170 | if len(configs) == 0: |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 1171 | if args.force_sync: |
Simon Glass | 793dca3 | 2019-10-31 07:42:57 -0600 | [diff] [blame] | 1172 | print('No CONFIG is specified. You are probably syncing defconfigs.', end=' ') |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 1173 | elif args.build_db: |
Simon Glass | 793dca3 | 2019-10-31 07:42:57 -0600 | [diff] [blame] | 1174 | print('Building %s database' % CONFIG_DATABASE) |
Masahiro Yamada | 6a9f79f | 2016-05-19 15:52:09 +0900 | [diff] [blame] | 1175 | else: |
Simon Glass | 793dca3 | 2019-10-31 07:42:57 -0600 | [diff] [blame] | 1176 | print('Neither CONFIG nor --force-sync is specified. Nothing will happen.', end=' ') |
Masahiro Yamada | 6a9f79f | 2016-05-19 15:52:09 +0900 | [diff] [blame] | 1177 | else: |
Simon Glass | 793dca3 | 2019-10-31 07:42:57 -0600 | [diff] [blame] | 1178 | print('Move ' + ', '.join(configs), end=' ') |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 1179 | print('(jobs: %d)\n' % args.jobs) |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 1180 | |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 1181 | if args.git_ref: |
| 1182 | reference_src = ReferenceSource(args.git_ref) |
Masahiro Yamada | 5cc42a5 | 2016-06-15 14:33:51 +0900 | [diff] [blame] | 1183 | reference_src_dir = reference_src.get_dir() |
| 1184 | else: |
Masahiro Yamada | f432c33 | 2016-06-15 14:33:52 +0900 | [diff] [blame] | 1185 | reference_src_dir = None |
Joe Hershberger | 6b96c1a | 2016-06-10 14:53:32 -0500 | [diff] [blame] | 1186 | |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 1187 | if args.defconfigs: |
| 1188 | defconfigs = get_matched_defconfigs(args.defconfigs) |
Joe Hershberger | 91040e8 | 2015-05-19 13:21:19 -0500 | [diff] [blame] | 1189 | else: |
Masahiro Yamada | 684c306 | 2016-07-25 19:15:28 +0900 | [diff] [blame] | 1190 | defconfigs = get_all_defconfigs() |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 1191 | |
Masahiro Yamada | c5e60fd | 2016-05-19 15:51:55 +0900 | [diff] [blame] | 1192 | progress = Progress(len(defconfigs)) |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 1193 | slots = Slots(toolchains, configs, args, progress, reference_src_dir, |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 1194 | db_queue) |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 1195 | |
| 1196 | # Main loop to process defconfig files: |
| 1197 | # Add a new subprocess into a vacant slot. |
| 1198 | # Sleep if there is no available slot. |
Masahiro Yamada | c5e60fd | 2016-05-19 15:51:55 +0900 | [diff] [blame] | 1199 | for defconfig in defconfigs: |
| 1200 | while not slots.add(defconfig): |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 1201 | while not slots.available(): |
| 1202 | # No available slot: sleep for a while |
| 1203 | time.sleep(SLEEP_TIME) |
| 1204 | |
| 1205 | # wait until all the subprocesses finish |
| 1206 | while not slots.empty(): |
| 1207 | time.sleep(SLEEP_TIME) |
| 1208 | |
Simon Glass | 793dca3 | 2019-10-31 07:42:57 -0600 | [diff] [blame] | 1209 | print('') |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 1210 | slots.show_failed_boards() |
Masahiro Yamada | fc2661e | 2016-06-15 14:33:54 +0900 | [diff] [blame] | 1211 | slots.show_suspicious_boards() |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 1212 | |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1213 | def find_kconfig_rules(kconf, config, imply_config): |
| 1214 | """Check whether a config has a 'select' or 'imply' keyword |
| 1215 | |
| 1216 | Args: |
Tom Rini | 65e05dd | 2019-09-20 17:42:09 -0400 | [diff] [blame] | 1217 | kconf: Kconfiglib.Kconfig object |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1218 | config: Name of config to check (without CONFIG_ prefix) |
| 1219 | imply_config: Implying config (without CONFIG_ prefix) which may or |
| 1220 | may not have an 'imply' for 'config') |
| 1221 | |
| 1222 | Returns: |
| 1223 | Symbol object for 'config' if found, else None |
| 1224 | """ |
Tom Rini | 65e05dd | 2019-09-20 17:42:09 -0400 | [diff] [blame] | 1225 | sym = kconf.syms.get(imply_config) |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1226 | if sym: |
Simon Glass | ea40b20 | 2021-07-21 21:35:53 -0600 | [diff] [blame] | 1227 | for sel, cond in (sym.selects + sym.implies): |
Simon Glass | a362708 | 2021-12-18 08:09:42 -0700 | [diff] [blame] | 1228 | if sel.name == config: |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1229 | return sym |
| 1230 | return None |
| 1231 | |
| 1232 | def check_imply_rule(kconf, config, imply_config): |
| 1233 | """Check if we can add an 'imply' option |
| 1234 | |
| 1235 | This finds imply_config in the Kconfig and looks to see if it is possible |
| 1236 | to add an 'imply' for 'config' to that part of the Kconfig. |
| 1237 | |
| 1238 | Args: |
Tom Rini | 65e05dd | 2019-09-20 17:42:09 -0400 | [diff] [blame] | 1239 | kconf: Kconfiglib.Kconfig object |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1240 | config: Name of config to check (without CONFIG_ prefix) |
| 1241 | imply_config: Implying config (without CONFIG_ prefix) which may or |
| 1242 | may not have an 'imply' for 'config') |
| 1243 | |
| 1244 | Returns: |
| 1245 | tuple: |
| 1246 | filename of Kconfig file containing imply_config, or None if none |
| 1247 | line number within the Kconfig file, or 0 if none |
| 1248 | message indicating the result |
| 1249 | """ |
Tom Rini | 65e05dd | 2019-09-20 17:42:09 -0400 | [diff] [blame] | 1250 | sym = kconf.syms.get(imply_config) |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1251 | if not sym: |
| 1252 | return 'cannot find sym' |
Simon Glass | ea40b20 | 2021-07-21 21:35:53 -0600 | [diff] [blame] | 1253 | nodes = sym.nodes |
| 1254 | if len(nodes) != 1: |
| 1255 | return '%d locations' % len(nodes) |
Simon Glass | a362708 | 2021-12-18 08:09:42 -0700 | [diff] [blame] | 1256 | node = nodes[0] |
| 1257 | fname, linenum = node.filename, node.linenr |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1258 | cwd = os.getcwd() |
| 1259 | if cwd and fname.startswith(cwd): |
| 1260 | fname = fname[len(cwd) + 1:] |
| 1261 | file_line = ' at %s:%d' % (fname, linenum) |
Simon Glass | 37f815c | 2021-12-18 14:54:34 -0700 | [diff] [blame] | 1262 | data = read_file(fname) |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1263 | if data[linenum - 1] != 'config %s' % imply_config: |
| 1264 | return None, 0, 'bad sym format %s%s' % (data[linenum], file_line) |
| 1265 | return fname, linenum, 'adding%s' % file_line |
| 1266 | |
| 1267 | def add_imply_rule(config, fname, linenum): |
| 1268 | """Add a new 'imply' option to a Kconfig |
| 1269 | |
| 1270 | Args: |
| 1271 | config: config option to add an imply for (without CONFIG_ prefix) |
| 1272 | fname: Kconfig filename to update |
| 1273 | linenum: Line number to place the 'imply' before |
| 1274 | |
| 1275 | Returns: |
| 1276 | Message indicating the result |
| 1277 | """ |
| 1278 | file_line = ' at %s:%d' % (fname, linenum) |
Simon Glass | 37f815c | 2021-12-18 14:54:34 -0700 | [diff] [blame] | 1279 | data = read_file(fname) |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1280 | linenum -= 1 |
| 1281 | |
| 1282 | for offset, line in enumerate(data[linenum:]): |
| 1283 | if line.strip().startswith('help') or not line: |
| 1284 | data.insert(linenum + offset, '\timply %s' % config) |
Simon Glass | 2fd85bd | 2021-12-18 14:54:33 -0700 | [diff] [blame] | 1285 | write_file(fname, data) |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1286 | return 'added%s' % file_line |
| 1287 | |
| 1288 | return 'could not insert%s' |
| 1289 | |
| 1290 | (IMPLY_MIN_2, IMPLY_TARGET, IMPLY_CMD, IMPLY_NON_ARCH_BOARD) = ( |
| 1291 | 1, 2, 4, 8) |
Simon Glass | 9b2a2e8 | 2017-06-15 21:39:32 -0600 | [diff] [blame] | 1292 | |
| 1293 | IMPLY_FLAGS = { |
| 1294 | 'min2': [IMPLY_MIN_2, 'Show options which imply >2 boards (normally >5)'], |
| 1295 | 'target': [IMPLY_TARGET, 'Allow CONFIG_TARGET_... options to imply'], |
| 1296 | 'cmd': [IMPLY_CMD, 'Allow CONFIG_CMD_... to imply'], |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1297 | 'non-arch-board': [ |
| 1298 | IMPLY_NON_ARCH_BOARD, |
| 1299 | 'Allow Kconfig options outside arch/ and /board/ to imply'], |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 1300 | } |
Simon Glass | 9b2a2e8 | 2017-06-15 21:39:32 -0600 | [diff] [blame] | 1301 | |
Simon Glass | 9d60339 | 2021-12-18 08:09:43 -0700 | [diff] [blame] | 1302 | |
| 1303 | def read_database(): |
| 1304 | """Read in the config database |
| 1305 | |
| 1306 | Returns: |
| 1307 | tuple: |
| 1308 | set of all config options seen (each a str) |
| 1309 | set of all defconfigs seen (each a str) |
| 1310 | dict of configs for each defconfig: |
| 1311 | key: defconfig name, e.g. "MPC8548CDS_legacy_defconfig" |
| 1312 | value: dict: |
| 1313 | key: CONFIG option |
| 1314 | value: Value of option |
| 1315 | dict of defconfigs for each config: |
| 1316 | key: CONFIG option |
| 1317 | value: set of boards using that option |
| 1318 | |
| 1319 | """ |
| 1320 | configs = {} |
| 1321 | |
| 1322 | # key is defconfig name, value is dict of (CONFIG_xxx, value) |
| 1323 | config_db = {} |
| 1324 | |
| 1325 | # Set of all config options we have seen |
| 1326 | all_configs = set() |
| 1327 | |
| 1328 | # Set of all defconfigs we have seen |
| 1329 | all_defconfigs = set() |
| 1330 | |
| 1331 | defconfig_db = collections.defaultdict(set) |
Simon Glass | 37f815c | 2021-12-18 14:54:34 -0700 | [diff] [blame] | 1332 | for line in read_file(CONFIG_DATABASE): |
| 1333 | line = line.rstrip() |
| 1334 | if not line: # Separator between defconfigs |
| 1335 | config_db[defconfig] = configs |
| 1336 | all_defconfigs.add(defconfig) |
| 1337 | configs = {} |
| 1338 | elif line[0] == ' ': # CONFIG line |
| 1339 | config, value = line.strip().split('=', 1) |
| 1340 | configs[config] = value |
| 1341 | defconfig_db[config].add(defconfig) |
| 1342 | all_configs.add(config) |
| 1343 | else: # New defconfig |
| 1344 | defconfig = line |
Simon Glass | 9d60339 | 2021-12-18 08:09:43 -0700 | [diff] [blame] | 1345 | |
| 1346 | return all_configs, all_defconfigs, config_db, defconfig_db |
| 1347 | |
| 1348 | |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1349 | def do_imply_config(config_list, add_imply, imply_flags, skip_added, |
| 1350 | check_kconfig=True, find_superset=False): |
Simon Glass | 99b6660 | 2017-06-01 19:39:03 -0600 | [diff] [blame] | 1351 | """Find CONFIG options which imply those in the list |
| 1352 | |
| 1353 | Some CONFIG options can be implied by others and this can help to reduce |
| 1354 | the size of the defconfig files. For example, CONFIG_X86 implies |
| 1355 | CONFIG_CMD_IRQ, so we can put 'imply CMD_IRQ' under 'config X86' and |
| 1356 | all x86 boards will have that option, avoiding adding CONFIG_CMD_IRQ to |
| 1357 | each of the x86 defconfig files. |
| 1358 | |
| 1359 | This function uses the moveconfig database to find such options. It |
| 1360 | displays a list of things that could possibly imply those in the list. |
| 1361 | The algorithm ignores any that start with CONFIG_TARGET since these |
| 1362 | typically refer to only a few defconfigs (often one). It also does not |
| 1363 | display a config with less than 5 defconfigs. |
| 1364 | |
| 1365 | The algorithm works using sets. For each target config in config_list: |
| 1366 | - Get the set 'defconfigs' which use that target config |
| 1367 | - For each config (from a list of all configs): |
| 1368 | - Get the set 'imply_defconfig' of defconfigs which use that config |
| 1369 | - |
| 1370 | - If imply_defconfigs contains anything not in defconfigs then |
| 1371 | this config does not imply the target config |
| 1372 | |
| 1373 | Params: |
| 1374 | config_list: List of CONFIG options to check (each a string) |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1375 | add_imply: Automatically add an 'imply' for each config. |
Simon Glass | 9b2a2e8 | 2017-06-15 21:39:32 -0600 | [diff] [blame] | 1376 | imply_flags: Flags which control which implying configs are allowed |
| 1377 | (IMPLY_...) |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1378 | skip_added: Don't show options which already have an imply added. |
| 1379 | check_kconfig: Check if implied symbols already have an 'imply' or |
| 1380 | 'select' for the target config, and show this information if so. |
Simon Glass | 99b6660 | 2017-06-01 19:39:03 -0600 | [diff] [blame] | 1381 | find_superset: True to look for configs which are a superset of those |
| 1382 | already found. So for example if CONFIG_EXYNOS5 implies an option, |
| 1383 | but CONFIG_EXYNOS covers a larger set of defconfigs and also |
| 1384 | implies that option, this will drop the former in favour of the |
| 1385 | latter. In practice this option has not proved very used. |
| 1386 | |
| 1387 | Note the terminoloy: |
| 1388 | config - a CONFIG_XXX options (a string, e.g. 'CONFIG_CMD_EEPROM') |
| 1389 | defconfig - a defconfig file (a string, e.g. 'configs/snow_defconfig') |
| 1390 | """ |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1391 | kconf = KconfigScanner().conf if check_kconfig else None |
| 1392 | if add_imply and add_imply != 'all': |
Simon Glass | a362708 | 2021-12-18 08:09:42 -0700 | [diff] [blame] | 1393 | add_imply = add_imply.split(',') |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1394 | |
Simon Glass | 9d60339 | 2021-12-18 08:09:43 -0700 | [diff] [blame] | 1395 | all_configs, all_defconfigs, config_db, defconfig_db = read_database() |
Simon Glass | 99b6660 | 2017-06-01 19:39:03 -0600 | [diff] [blame] | 1396 | |
Simon Glass | a362708 | 2021-12-18 08:09:42 -0700 | [diff] [blame] | 1397 | # Work through each target config option in turn, independently |
Simon Glass | 99b6660 | 2017-06-01 19:39:03 -0600 | [diff] [blame] | 1398 | for config in config_list: |
| 1399 | defconfigs = defconfig_db.get(config) |
| 1400 | if not defconfigs: |
Simon Glass | 793dca3 | 2019-10-31 07:42:57 -0600 | [diff] [blame] | 1401 | print('%s not found in any defconfig' % config) |
Simon Glass | 99b6660 | 2017-06-01 19:39:03 -0600 | [diff] [blame] | 1402 | continue |
| 1403 | |
| 1404 | # Get the set of defconfigs without this one (since a config cannot |
| 1405 | # imply itself) |
| 1406 | non_defconfigs = all_defconfigs - defconfigs |
| 1407 | num_defconfigs = len(defconfigs) |
Simon Glass | 793dca3 | 2019-10-31 07:42:57 -0600 | [diff] [blame] | 1408 | print('%s found in %d/%d defconfigs' % (config, num_defconfigs, |
| 1409 | len(all_configs))) |
Simon Glass | 99b6660 | 2017-06-01 19:39:03 -0600 | [diff] [blame] | 1410 | |
| 1411 | # This will hold the results: key=config, value=defconfigs containing it |
| 1412 | imply_configs = {} |
| 1413 | rest_configs = all_configs - set([config]) |
| 1414 | |
| 1415 | # Look at every possible config, except the target one |
| 1416 | for imply_config in rest_configs: |
Simon Glass | 9b2a2e8 | 2017-06-15 21:39:32 -0600 | [diff] [blame] | 1417 | if 'ERRATUM' in imply_config: |
Simon Glass | 99b6660 | 2017-06-01 19:39:03 -0600 | [diff] [blame] | 1418 | continue |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 1419 | if not imply_flags & IMPLY_CMD: |
Simon Glass | 9b2a2e8 | 2017-06-15 21:39:32 -0600 | [diff] [blame] | 1420 | if 'CONFIG_CMD' in imply_config: |
| 1421 | continue |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 1422 | if not imply_flags & IMPLY_TARGET: |
Simon Glass | 9b2a2e8 | 2017-06-15 21:39:32 -0600 | [diff] [blame] | 1423 | if 'CONFIG_TARGET' in imply_config: |
| 1424 | continue |
Simon Glass | 99b6660 | 2017-06-01 19:39:03 -0600 | [diff] [blame] | 1425 | |
| 1426 | # Find set of defconfigs that have this config |
| 1427 | imply_defconfig = defconfig_db[imply_config] |
| 1428 | |
| 1429 | # Get the intersection of this with defconfigs containing the |
| 1430 | # target config |
| 1431 | common_defconfigs = imply_defconfig & defconfigs |
| 1432 | |
| 1433 | # Get the set of defconfigs containing this config which DO NOT |
| 1434 | # also contain the taret config. If this set is non-empty it means |
| 1435 | # that this config affects other defconfigs as well as (possibly) |
| 1436 | # the ones affected by the target config. This means it implies |
| 1437 | # things we don't want to imply. |
| 1438 | not_common_defconfigs = imply_defconfig & non_defconfigs |
| 1439 | if not_common_defconfigs: |
| 1440 | continue |
| 1441 | |
| 1442 | # If there are common defconfigs, imply_config may be useful |
| 1443 | if common_defconfigs: |
| 1444 | skip = False |
| 1445 | if find_superset: |
Simon Glass | 793dca3 | 2019-10-31 07:42:57 -0600 | [diff] [blame] | 1446 | for prev in list(imply_configs.keys()): |
Simon Glass | 99b6660 | 2017-06-01 19:39:03 -0600 | [diff] [blame] | 1447 | prev_count = len(imply_configs[prev]) |
| 1448 | count = len(common_defconfigs) |
| 1449 | if (prev_count > count and |
| 1450 | (imply_configs[prev] & common_defconfigs == |
| 1451 | common_defconfigs)): |
| 1452 | # skip imply_config because prev is a superset |
| 1453 | skip = True |
| 1454 | break |
| 1455 | elif count > prev_count: |
| 1456 | # delete prev because imply_config is a superset |
| 1457 | del imply_configs[prev] |
| 1458 | if not skip: |
| 1459 | imply_configs[imply_config] = common_defconfigs |
| 1460 | |
| 1461 | # Now we have a dict imply_configs of configs which imply each config |
| 1462 | # The value of each dict item is the set of defconfigs containing that |
| 1463 | # config. Rank them so that we print the configs that imply the largest |
| 1464 | # number of defconfigs first. |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1465 | ranked_iconfigs = sorted(imply_configs, |
Simon Glass | 99b6660 | 2017-06-01 19:39:03 -0600 | [diff] [blame] | 1466 | key=lambda k: len(imply_configs[k]), reverse=True) |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1467 | kconfig_info = '' |
| 1468 | cwd = os.getcwd() |
| 1469 | add_list = collections.defaultdict(list) |
| 1470 | for iconfig in ranked_iconfigs: |
| 1471 | num_common = len(imply_configs[iconfig]) |
Simon Glass | 99b6660 | 2017-06-01 19:39:03 -0600 | [diff] [blame] | 1472 | |
| 1473 | # Don't bother if there are less than 5 defconfigs affected. |
Simon Glass | 9b2a2e8 | 2017-06-15 21:39:32 -0600 | [diff] [blame] | 1474 | if num_common < (2 if imply_flags & IMPLY_MIN_2 else 5): |
Simon Glass | 99b6660 | 2017-06-01 19:39:03 -0600 | [diff] [blame] | 1475 | continue |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1476 | missing = defconfigs - imply_configs[iconfig] |
Simon Glass | 99b6660 | 2017-06-01 19:39:03 -0600 | [diff] [blame] | 1477 | missing_str = ', '.join(missing) if missing else 'all' |
| 1478 | missing_str = '' |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1479 | show = True |
| 1480 | if kconf: |
| 1481 | sym = find_kconfig_rules(kconf, config[CONFIG_LEN:], |
| 1482 | iconfig[CONFIG_LEN:]) |
| 1483 | kconfig_info = '' |
| 1484 | if sym: |
Simon Glass | ea40b20 | 2021-07-21 21:35:53 -0600 | [diff] [blame] | 1485 | nodes = sym.nodes |
| 1486 | if len(nodes) == 1: |
| 1487 | fname, linenum = nodes[0].filename, nodes[0].linenr |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1488 | if cwd and fname.startswith(cwd): |
| 1489 | fname = fname[len(cwd) + 1:] |
| 1490 | kconfig_info = '%s:%d' % (fname, linenum) |
| 1491 | if skip_added: |
| 1492 | show = False |
| 1493 | else: |
Tom Rini | 65e05dd | 2019-09-20 17:42:09 -0400 | [diff] [blame] | 1494 | sym = kconf.syms.get(iconfig[CONFIG_LEN:]) |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1495 | fname = '' |
| 1496 | if sym: |
Simon Glass | ea40b20 | 2021-07-21 21:35:53 -0600 | [diff] [blame] | 1497 | nodes = sym.nodes |
| 1498 | if len(nodes) == 1: |
| 1499 | fname, linenum = nodes[0].filename, nodes[0].linenr |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1500 | if cwd and fname.startswith(cwd): |
| 1501 | fname = fname[len(cwd) + 1:] |
| 1502 | in_arch_board = not sym or (fname.startswith('arch') or |
| 1503 | fname.startswith('board')) |
| 1504 | if (not in_arch_board and |
Simon Glass | 91197aa | 2021-12-18 14:54:35 -0700 | [diff] [blame] | 1505 | not imply_flags & IMPLY_NON_ARCH_BOARD): |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1506 | continue |
| 1507 | |
| 1508 | if add_imply and (add_imply == 'all' or |
| 1509 | iconfig in add_imply): |
| 1510 | fname, linenum, kconfig_info = (check_imply_rule(kconf, |
| 1511 | config[CONFIG_LEN:], iconfig[CONFIG_LEN:])) |
| 1512 | if fname: |
| 1513 | add_list[fname].append(linenum) |
| 1514 | |
| 1515 | if show and kconfig_info != 'skip': |
Simon Glass | 793dca3 | 2019-10-31 07:42:57 -0600 | [diff] [blame] | 1516 | print('%5d : %-30s%-25s %s' % (num_common, iconfig.ljust(30), |
| 1517 | kconfig_info, missing_str)) |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1518 | |
| 1519 | # Having collected a list of things to add, now we add them. We process |
| 1520 | # each file from the largest line number to the smallest so that |
| 1521 | # earlier additions do not affect our line numbers. E.g. if we added an |
| 1522 | # imply at line 20 it would change the position of each line after |
| 1523 | # that. |
Simon Glass | 793dca3 | 2019-10-31 07:42:57 -0600 | [diff] [blame] | 1524 | for fname, linenums in add_list.items(): |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1525 | for linenum in sorted(linenums, reverse=True): |
| 1526 | add_imply_rule(config[CONFIG_LEN:], fname, linenum) |
Simon Glass | 99b6660 | 2017-06-01 19:39:03 -0600 | [diff] [blame] | 1527 | |
Simon Glass | 941671a | 2022-02-08 11:49:46 -0700 | [diff] [blame] | 1528 | def defconfig_matches(configs, re_match): |
| 1529 | """Check if any CONFIG option matches a regex |
| 1530 | |
| 1531 | The match must be complete, i.e. from the start to end of the CONFIG option. |
| 1532 | |
| 1533 | Args: |
| 1534 | configs (dict): Dict of CONFIG options: |
| 1535 | key: CONFIG option |
| 1536 | value: Value of option |
| 1537 | re_match (re.Pattern): Match to check |
| 1538 | |
| 1539 | Returns: |
| 1540 | bool: True if any CONFIG matches the regex |
| 1541 | """ |
| 1542 | for cfg in configs: |
Simon Glass | d9c958f | 2022-03-05 20:18:54 -0700 | [diff] [blame] | 1543 | if re_match.fullmatch(cfg): |
Simon Glass | 941671a | 2022-02-08 11:49:46 -0700 | [diff] [blame] | 1544 | return True |
| 1545 | return False |
Simon Glass | 99b6660 | 2017-06-01 19:39:03 -0600 | [diff] [blame] | 1546 | |
Simon Glass | 65d7fce | 2021-12-18 08:09:46 -0700 | [diff] [blame] | 1547 | def do_find_config(config_list): |
| 1548 | """Find boards with a given combination of CONFIGs |
| 1549 | |
| 1550 | Params: |
Simon Glass | 941671a | 2022-02-08 11:49:46 -0700 | [diff] [blame] | 1551 | config_list: List of CONFIG options to check (each a regex consisting |
Simon Glass | 65d7fce | 2021-12-18 08:09:46 -0700 | [diff] [blame] | 1552 | of a config option, with or without a CONFIG_ prefix. If an option |
| 1553 | is preceded by a tilde (~) then it must be false, otherwise it must |
| 1554 | be true) |
| 1555 | """ |
| 1556 | all_configs, all_defconfigs, config_db, defconfig_db = read_database() |
| 1557 | |
Simon Glass | 65d7fce | 2021-12-18 08:09:46 -0700 | [diff] [blame] | 1558 | # Start with all defconfigs |
| 1559 | out = all_defconfigs |
| 1560 | |
| 1561 | # Work through each config in turn |
Simon Glass | 65d7fce | 2021-12-18 08:09:46 -0700 | [diff] [blame] | 1562 | for item in config_list: |
| 1563 | # Get the real config name and whether we want this config or not |
| 1564 | cfg = item |
| 1565 | want = True |
| 1566 | if cfg[0] == '~': |
| 1567 | want = False |
| 1568 | cfg = cfg[1:] |
| 1569 | |
Simon Glass | 65d7fce | 2021-12-18 08:09:46 -0700 | [diff] [blame] | 1570 | # Search everything that is still in the running. If it has a config |
| 1571 | # that we want, or doesn't have one that we don't, add it into the |
| 1572 | # running for the next stage |
| 1573 | in_list = out |
| 1574 | out = set() |
Simon Glass | 941671a | 2022-02-08 11:49:46 -0700 | [diff] [blame] | 1575 | re_match = re.compile(cfg) |
Simon Glass | 65d7fce | 2021-12-18 08:09:46 -0700 | [diff] [blame] | 1576 | for defc in in_list: |
Simon Glass | 941671a | 2022-02-08 11:49:46 -0700 | [diff] [blame] | 1577 | has_cfg = defconfig_matches(config_db[defc], re_match) |
Simon Glass | 65d7fce | 2021-12-18 08:09:46 -0700 | [diff] [blame] | 1578 | if has_cfg == want: |
| 1579 | out.add(defc) |
Tom Rini | 9ef3ba8 | 2022-12-04 10:14:16 -0500 | [diff] [blame] | 1580 | print(f'{len(out)} matches') |
| 1581 | print(' '.join(item.split('_defconfig')[0] for item in out)) |
Simon Glass | 65d7fce | 2021-12-18 08:09:46 -0700 | [diff] [blame] | 1582 | |
| 1583 | |
| 1584 | def prefix_config(cfg): |
| 1585 | """Prefix a config with CONFIG_ if needed |
| 1586 | |
| 1587 | This handles ~ operator, which indicates that the CONFIG should be disabled |
| 1588 | |
| 1589 | >>> prefix_config('FRED') |
| 1590 | 'CONFIG_FRED' |
| 1591 | >>> prefix_config('CONFIG_FRED') |
| 1592 | 'CONFIG_FRED' |
| 1593 | >>> prefix_config('~FRED') |
| 1594 | '~CONFIG_FRED' |
| 1595 | >>> prefix_config('~CONFIG_FRED') |
| 1596 | '~CONFIG_FRED' |
| 1597 | >>> prefix_config('A123') |
| 1598 | 'CONFIG_A123' |
| 1599 | """ |
| 1600 | op = '' |
| 1601 | if cfg[0] == '~': |
| 1602 | op = cfg[0] |
| 1603 | cfg = cfg[1:] |
| 1604 | if not cfg.startswith('CONFIG_'): |
| 1605 | cfg = 'CONFIG_' + cfg |
| 1606 | return op + cfg |
| 1607 | |
| 1608 | |
Simon Glass | 65e6203 | 2023-02-01 13:19:12 -0700 | [diff] [blame] | 1609 | RE_MK_CONFIGS = re.compile('CONFIG_(\$\(SPL_(?:TPL_)?\))?([A-Za-z0-9_]*)') |
| 1610 | RE_IFDEF = re.compile('(ifdef|ifndef)') |
| 1611 | RE_C_CONFIGS = re.compile('CONFIG_([A-Za-z0-9_]*)') |
| 1612 | RE_CONFIG_IS = re.compile('CONFIG_IS_ENABLED\(([A-Za-z0-9_]*)\)') |
| 1613 | |
| 1614 | class ConfigUse: |
| 1615 | def __init__(self, cfg, is_spl, fname, rest): |
| 1616 | self.cfg = cfg |
| 1617 | self.is_spl = is_spl |
| 1618 | self.fname = fname |
| 1619 | self.rest = rest |
| 1620 | |
| 1621 | def __hash__(self): |
| 1622 | return hash((self.cfg, self.is_spl)) |
| 1623 | |
| 1624 | def scan_makefiles(fnames): |
| 1625 | """Scan Makefiles looking for Kconfig options |
| 1626 | |
| 1627 | Looks for uses of CONFIG options in Makefiles |
| 1628 | |
| 1629 | Args: |
| 1630 | fnames (list of tuple): |
| 1631 | str: Makefile filename where the option was found |
| 1632 | str: Line of the Makefile |
| 1633 | |
| 1634 | Returns: |
| 1635 | tuple: |
| 1636 | dict: all_uses |
| 1637 | key (ConfigUse): object |
| 1638 | value (list of str): matching lines |
| 1639 | dict: Uses by filename |
| 1640 | key (str): filename |
| 1641 | value (set of ConfigUse): uses in that filename |
| 1642 | |
| 1643 | >>> RE_MK_CONFIGS.search('CONFIG_FRED').groups() |
| 1644 | (None, 'FRED') |
| 1645 | >>> RE_MK_CONFIGS.search('CONFIG_$(SPL_)MARY').groups() |
| 1646 | ('$(SPL_)', 'MARY') |
| 1647 | >>> RE_MK_CONFIGS.search('CONFIG_$(SPL_TPL_)MARY').groups() |
| 1648 | ('$(SPL_TPL_)', 'MARY') |
| 1649 | """ |
| 1650 | all_uses = collections.defaultdict(list) |
| 1651 | fname_uses = {} |
| 1652 | for fname, rest in fnames: |
| 1653 | m_iter = RE_MK_CONFIGS.finditer(rest) |
| 1654 | found = False |
| 1655 | for m in m_iter: |
| 1656 | found = True |
| 1657 | real_opt = m.group(2) |
| 1658 | if real_opt == '': |
| 1659 | continue |
| 1660 | is_spl = False |
| 1661 | if m.group(1): |
| 1662 | is_spl = True |
| 1663 | use = ConfigUse(real_opt, is_spl, fname, rest) |
| 1664 | if fname not in fname_uses: |
| 1665 | fname_uses[fname] = set() |
| 1666 | fname_uses[fname].add(use) |
| 1667 | all_uses[use].append(rest) |
| 1668 | return all_uses, fname_uses |
| 1669 | |
| 1670 | |
| 1671 | def scan_src_files(fnames): |
| 1672 | """Scan source files (other than Makefiles) looking for Kconfig options |
| 1673 | |
| 1674 | Looks for uses of CONFIG options |
| 1675 | |
| 1676 | Args: |
| 1677 | fnames (list of tuple): |
| 1678 | str: Makefile filename where the option was found |
| 1679 | str: Line of the Makefile |
| 1680 | |
| 1681 | Returns: |
| 1682 | tuple: |
| 1683 | dict: all_uses |
| 1684 | key (ConfigUse): object |
| 1685 | value (list of str): matching lines |
| 1686 | dict: Uses by filename |
| 1687 | key (str): filename |
| 1688 | value (set of ConfigUse): uses in that filename |
| 1689 | |
| 1690 | >>> RE_C_CONFIGS.search('CONFIG_FRED').groups() |
| 1691 | ('FRED',) |
| 1692 | >>> RE_CONFIG_IS.search('CONFIG_IS_ENABLED(MARY)').groups() |
| 1693 | ('MARY',) |
| 1694 | >>> RE_CONFIG_IS.search('#if CONFIG_IS_ENABLED(OF_PLATDATA)').groups() |
| 1695 | ('OF_PLATDATA',) |
| 1696 | """ |
| 1697 | def add_uses(m_iter, is_spl): |
| 1698 | for m in m_iter: |
| 1699 | found = True |
| 1700 | real_opt = m.group(1) |
| 1701 | if real_opt == '': |
| 1702 | continue |
| 1703 | use = ConfigUse(real_opt, is_spl, fname, rest) |
| 1704 | if fname not in fname_uses: |
| 1705 | fname_uses[fname] = set() |
| 1706 | fname_uses[fname].add(use) |
| 1707 | all_uses[use].append(rest) |
| 1708 | |
| 1709 | all_uses = collections.defaultdict(list) |
| 1710 | fname_uses = {} |
| 1711 | for fname, rest in fnames: |
| 1712 | m_iter = RE_C_CONFIGS.finditer(rest) |
| 1713 | add_uses(m_iter, False) |
| 1714 | |
| 1715 | m_iter2 = RE_CONFIG_IS.finditer(rest) |
| 1716 | add_uses(m_iter2, True) |
| 1717 | |
| 1718 | return all_uses, fname_uses |
| 1719 | |
| 1720 | |
| 1721 | MODE_NORMAL, MODE_SPL, MODE_PROPER = range(3) |
| 1722 | |
| 1723 | def do_scan_source(path, do_update): |
| 1724 | """Scan the source tree for Kconfig inconsistencies |
| 1725 | |
| 1726 | Args: |
| 1727 | path (str): Path to source tree |
| 1728 | do_update (bool) : True to write to scripts/kconf_... files |
| 1729 | """ |
| 1730 | def is_not_proper(name): |
| 1731 | for prefix in SPL_PREFIXES: |
| 1732 | if name.startswith(prefix): |
| 1733 | return name[len(prefix):] |
| 1734 | return False |
| 1735 | |
| 1736 | def check_not_found(all_uses, spl_mode): |
| 1737 | """Check for Kconfig options mentioned in the source but not in Kconfig |
| 1738 | |
| 1739 | Args: |
| 1740 | all_uses (dict): |
| 1741 | key (ConfigUse): object |
| 1742 | value (list of str): matching lines |
| 1743 | spl_mode (int): If MODE_SPL, look at source code which implies |
| 1744 | an SPL_ option, but for which there is none; |
| 1745 | for MOD_PROPER, look at source code which implies a Proper |
| 1746 | option (i.e. use of CONFIG_IS_ENABLED() or $(SPL_) or |
| 1747 | $(SPL_TPL_) but for which there none; |
| 1748 | if MODE_NORMAL, ignore SPL |
| 1749 | |
| 1750 | Returns: |
| 1751 | dict: |
| 1752 | key (str): CONFIG name (without 'CONFIG_' prefix |
| 1753 | value (list of ConfigUse): List of uses of this CONFIG |
| 1754 | """ |
| 1755 | # Make sure we know about all the options |
| 1756 | not_found = collections.defaultdict(list) |
| 1757 | for use, rest in all_uses.items(): |
| 1758 | name = use.cfg |
| 1759 | if name in IGNORE_SYMS: |
| 1760 | continue |
| 1761 | check = True |
| 1762 | |
| 1763 | if spl_mode == MODE_SPL: |
| 1764 | check = use.is_spl |
| 1765 | |
| 1766 | # If it is an SPL symbol, try prepending all SPL_ prefixes to |
| 1767 | # find at least one SPL symbol |
| 1768 | if use.is_spl: |
| 1769 | add_to_dict = False |
| 1770 | for prefix in SPL_PREFIXES: |
| 1771 | try_name = prefix + name |
| 1772 | sym = kconf.syms.get(try_name) |
| 1773 | if sym: |
| 1774 | break |
| 1775 | if not sym: |
| 1776 | not_found[f'SPL_{name}'].append(use) |
| 1777 | continue |
| 1778 | elif spl_mode == MODE_PROPER: |
| 1779 | # Try to find the Proper version of this symbol, i.e. without |
| 1780 | # the SPL_ prefix |
| 1781 | proper_name = is_not_proper(name) |
| 1782 | if proper_name: |
| 1783 | name = proper_name |
| 1784 | elif not use.is_spl: |
| 1785 | check = False |
| 1786 | else: # MODE_NORMAL |
| 1787 | debug = False |
| 1788 | sym = kconf.syms.get(name) |
| 1789 | if not sym: |
| 1790 | proper_name = is_not_proper(name) |
| 1791 | if proper_name: |
| 1792 | name = proper_name |
| 1793 | sym = kconf.syms.get(name) |
| 1794 | if not sym: |
| 1795 | for prefix in SPL_PREFIXES: |
| 1796 | try_name = prefix + name |
| 1797 | sym = kconf.syms.get(try_name) |
| 1798 | if sym: |
| 1799 | break |
| 1800 | if not sym: |
| 1801 | not_found[name].append(use) |
| 1802 | continue |
| 1803 | |
| 1804 | sym = kconf.syms.get(name) |
| 1805 | if not sym and check: |
| 1806 | not_found[name].append(use) |
| 1807 | return not_found |
| 1808 | |
| 1809 | def show_uses(uses): |
| 1810 | """Show a list of uses along with their filename and code snippet |
| 1811 | |
| 1812 | Args: |
| 1813 | uses (dict): |
| 1814 | key (str): CONFIG name (without 'CONFIG_' prefix |
| 1815 | value (list of ConfigUse): List of uses of this CONFIG |
| 1816 | """ |
| 1817 | for name in sorted(uses): |
| 1818 | print(f'{name}: ', end='') |
| 1819 | for i, use in enumerate(uses[name]): |
| 1820 | print(f'{" " if i else ""}{use.fname}: {use.rest.strip()}') |
| 1821 | |
| 1822 | |
| 1823 | print('Scanning Kconfig') |
| 1824 | kconf = KconfigScanner().conf |
| 1825 | print(f'Scanning source in {path}') |
| 1826 | args = ['git', 'grep', '-E', r'IS_ENABLED|\bCONFIG'] |
| 1827 | with subprocess.Popen(args, stdout=subprocess.PIPE) as proc: |
| 1828 | out, err = proc.communicate() |
| 1829 | lines = out.splitlines() |
| 1830 | re_fname = re.compile('^([^:]*):(.*)') |
| 1831 | src_list = [] |
| 1832 | mk_list = [] |
| 1833 | for line in lines: |
| 1834 | linestr = line.decode('utf-8') |
| 1835 | m_fname = re_fname.search(linestr) |
| 1836 | if not m_fname: |
| 1837 | continue |
| 1838 | fname, rest = m_fname.groups() |
| 1839 | dirname, leaf = os.path.split(fname) |
| 1840 | root, ext = os.path.splitext(leaf) |
| 1841 | if ext == '.autoconf': |
| 1842 | pass |
| 1843 | elif ext in ['.c', '.h', '.S', '.lds', '.dts', '.dtsi', '.asl', '.cfg', |
| 1844 | '.env', '.tmpl']: |
| 1845 | src_list.append([fname, rest]) |
| 1846 | elif 'Makefile' in root or ext == '.mk': |
| 1847 | mk_list.append([fname, rest]) |
| 1848 | elif ext in ['.yml', '.sh', '.py', '.awk', '.pl', '.rst', '', '.sed']: |
| 1849 | pass |
| 1850 | elif 'Kconfig' in root or 'Kbuild' in root: |
| 1851 | pass |
| 1852 | elif 'README' in root: |
| 1853 | pass |
| 1854 | elif dirname in ['configs']: |
| 1855 | pass |
| 1856 | elif dirname.startswith('doc') or dirname.startswith('scripts/kconfig'): |
| 1857 | pass |
| 1858 | else: |
| 1859 | print(f'Not sure how to handle file {fname}') |
| 1860 | |
| 1861 | # Scan the Makefiles |
| 1862 | all_uses, fname_uses = scan_makefiles(mk_list) |
| 1863 | |
| 1864 | spl_not_found = set() |
| 1865 | proper_not_found = set() |
| 1866 | |
| 1867 | # Make sure we know about all the options |
| 1868 | print('\nCONFIG options present in Makefiles but not Kconfig:') |
| 1869 | not_found = check_not_found(all_uses, MODE_NORMAL) |
| 1870 | show_uses(not_found) |
| 1871 | |
| 1872 | print('\nCONFIG options present in Makefiles but not Kconfig (SPL):') |
| 1873 | not_found = check_not_found(all_uses, MODE_SPL) |
| 1874 | show_uses(not_found) |
| 1875 | spl_not_found |= set([is_not_proper(key) or key for key in not_found.keys()]) |
| 1876 | |
| 1877 | print('\nCONFIG options used as Proper in Makefiles but without a non-SPL_ variant:') |
| 1878 | not_found = check_not_found(all_uses, MODE_PROPER) |
| 1879 | show_uses(not_found) |
| 1880 | proper_not_found |= set([key for key in not_found.keys()]) |
| 1881 | |
| 1882 | # Scan the source code |
| 1883 | all_uses, fname_uses = scan_src_files(src_list) |
| 1884 | |
| 1885 | # Make sure we know about all the options |
| 1886 | print('\nCONFIG options present in source but not Kconfig:') |
| 1887 | not_found = check_not_found(all_uses, MODE_NORMAL) |
| 1888 | show_uses(not_found) |
| 1889 | |
| 1890 | print('\nCONFIG options present in source but not Kconfig (SPL):') |
| 1891 | not_found = check_not_found(all_uses, MODE_SPL) |
| 1892 | show_uses(not_found) |
| 1893 | spl_not_found |= set([is_not_proper(key) or key for key in not_found.keys()]) |
| 1894 | |
| 1895 | print('\nCONFIG options used as Proper in source but without a non-SPL_ variant:') |
| 1896 | not_found = check_not_found(all_uses, MODE_PROPER) |
| 1897 | show_uses(not_found) |
| 1898 | proper_not_found |= set([key for key in not_found.keys()]) |
| 1899 | |
| 1900 | print('\nCONFIG options used as SPL but without an SPL_ variant:') |
| 1901 | for item in sorted(spl_not_found): |
| 1902 | print(f' {item}') |
| 1903 | |
| 1904 | print('\nCONFIG options used as Proper but without a non-SPL_ variant:') |
| 1905 | for item in sorted(proper_not_found): |
| 1906 | print(f' {item}') |
| 1907 | |
| 1908 | # Write out the updated information |
| 1909 | if do_update: |
| 1910 | with open(os.path.join(path, 'scripts', 'conf_nospl'), 'w') as out: |
| 1911 | print('# These options should not be enabled in SPL builds\n', |
| 1912 | file=out) |
| 1913 | for item in sorted(spl_not_found): |
| 1914 | print(item, file=out) |
| 1915 | with open(os.path.join(path, 'scripts', 'conf_noproper'), 'w') as out: |
| 1916 | print('# These options should not be enabled in Proper builds\n', |
| 1917 | file=out) |
| 1918 | for item in sorted(proper_not_found): |
| 1919 | print(item, file=out) |
| 1920 | |
| 1921 | |
Masahiro Yamada | 5a27c73 | 2015-05-20 11:36:07 +0900 | [diff] [blame] | 1922 | def main(): |
| 1923 | try: |
| 1924 | cpu_count = multiprocessing.cpu_count() |
| 1925 | except NotImplementedError: |
| 1926 | cpu_count = 1 |
| 1927 | |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 1928 | epilog = '''Move config options from headers to defconfig files. See |
| 1929 | doc/develop/moveconfig.rst for documentation.''' |
| 1930 | |
| 1931 | parser = ArgumentParser(epilog=epilog) |
| 1932 | # Add arguments here |
| 1933 | parser.add_argument('-a', '--add-imply', type=str, default='', |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | [diff] [blame] | 1934 | help='comma-separated list of CONFIG options to add ' |
| 1935 | "an 'imply' statement to for the CONFIG in -i") |
Simon Glass | b2e83c6 | 2021-12-18 14:54:31 -0700 | [diff] [blame] | 1936 | parser.add_argument('-A', '--skip-added', action='store_true', default=False, |
Simon Glass | cb00883 | 2017-06-15 21:39:33 -0600 | |