dm: sandbox: Switch over to using the new host uclass
Update the sandbox implementation to use UCLASS_HOST and adjust all
the pieces to continue to work:
- Update the 'host' command to use the new API
- Replace various uses of UCLASS_ROOT with UCLASS_HOST
- Disable test_eficonfig since it doesn't work (this should have a unit
test to allow this to be debugged)
- Update the blk test to use the new API
- Drop the old header file
Unfortunately it does not seem to be possible to split this change up
further.
Signed-off-by: Simon Glass <sjg@chromium.org>
diff --git a/cmd/host.c b/cmd/host.c
index f09ac8d..fb1cb1f 100644
--- a/cmd/host.c
+++ b/cmd/host.c
@@ -8,12 +8,12 @@
#include <dm.h>
#include <fs.h>
#include <part.h>
-#include <sandboxblockdev.h>
+#include <sandbox_host.h>
#include <dm/device_compat.h>
+#include <dm/device-internal.h>
+#include <dm/uclass-internal.h>
#include <linux/errno.h>
-static int host_curr_device = -1;
-
static int do_host_load(struct cmd_tbl *cmdtp, int flag, int argc,
char *const argv[])
{
@@ -42,10 +42,10 @@
char *const argv[])
{
bool removable = false;
- const char *dev_str;
+ struct udevice *dev;
+ const char *label;
char *file;
- char *ep;
- int dev;
+ int ret;
/* Skip 'bind' */
argc--;
@@ -61,97 +61,158 @@
if (argc > 2)
return CMD_RET_USAGE;
- dev_str = argv[0];
- dev = hextoul(dev_str, &ep);
- if (*ep) {
- printf("** Bad device specification %s **\n", dev_str);
- return CMD_RET_USAGE;
- }
+ label = argv[0];
file = argc > 1 ? argv[1] : NULL;
- return !!host_dev_bind(dev, file, removable);
+ ret = host_create_attach_file(label, file, removable, &dev);
+ if (ret) {
+ printf("Cannot create device / bind file\n");
+ return CMD_RET_FAILURE;
+ }
+
+ return 0;
+}
+
+/**
+ * parse_host_label() - Parse a device label or sequence number
+ *
+ * This shows an error if it returns NULL
+ *
+ * @label: String containing the label or sequence number
+ * Returns: Associated device, or NULL if not found
+ */
+static struct udevice *parse_host_label(const char *label)
+{
+ struct udevice *dev;
+
+ dev = host_find_by_label(label);
+ if (!dev) {
+ int devnum;
+ char *ep;
+
+ devnum = hextoul(label, &ep);
+ if (*ep ||
+ uclass_find_device_by_seq(UCLASS_HOST, devnum, &dev)) {
+ printf("No such device '%s'\n", label);
+ return NULL;
+ }
+ }
+
+ return dev;
+}
+
+static int do_host_unbind(struct cmd_tbl *cmdtp, int flag, int argc,
+ char *const argv[])
+{
+ struct udevice *dev;
+ const char *label;
+ int ret;
+
+ if (argc < 2)
+ return CMD_RET_USAGE;
+
+ label = argv[1];
+ dev = parse_host_label(label);
+ if (!dev)
+ return CMD_RET_FAILURE;
+
+ ret = host_detach_file(dev);
+ if (ret) {
+ printf("Cannot detach file (err=%d)\n", ret);
+ return CMD_RET_FAILURE;
+ }
+
+ ret = device_unbind(dev);
+ if (ret) {
+ printf("Cannot attach file\n");
+ ret = device_unbind(dev);
+ if (ret)
+ printf("Cannot unbind device '%s'\n", dev->name);
+ return CMD_RET_FAILURE;
+ }
+
+ return 0;
+}
+
+static void show_host_dev(struct udevice *dev)
+{
+ struct host_sb_plat *plat = dev_get_plat(dev);
+ struct blk_desc *desc;
+ struct udevice *blk;
+ int ret;
+
+ printf("%3d ", dev_seq(dev));
+ if (!plat->fd) {
+ printf("Not bound to a backing file\n");
+ return;
+ }
+ ret = blk_get_from_parent(dev, &blk);
+ if (ret) /* cannot happen */
+ return;
+
+ desc = dev_get_uclass_plat(blk);
+ printf("%12lu %-15s %s\n", (unsigned long)desc->lba, plat->label,
+ plat->filename);
}
static int do_host_info(struct cmd_tbl *cmdtp, int flag, int argc,
char *const argv[])
{
- if (argc < 1 || argc > 2)
+ struct udevice *dev;
+
+ if (argc < 1)
return CMD_RET_USAGE;
- int min_dev = 0;
- int max_dev = SANDBOX_HOST_MAX_DEVICES - 1;
+
+ dev = NULL;
if (argc >= 2) {
- char *ep;
- char *dev_str = argv[1];
- int dev = hextoul(dev_str, &ep);
- if (*ep) {
- printf("** Bad device specification %s **\n", dev_str);
- return CMD_RET_USAGE;
- }
- min_dev = dev;
- max_dev = dev;
+ dev = parse_host_label(argv[1]);
+ if (!dev)
+ return CMD_RET_FAILURE;
}
- int dev;
- printf("%3s %12s %s\n", "dev", "blocks", "path");
- for (dev = min_dev; dev <= max_dev; dev++) {
- struct blk_desc *blk_dev;
- int ret;
- printf("%3d ", dev);
- ret = host_get_dev_err(dev, &blk_dev);
- if (ret) {
- if (ret == -ENOENT)
- puts("Not bound to a backing file\n");
- else if (ret == -ENODEV)
- puts("Invalid host device number\n");
+ printf("%3s %12s %-15s %s\n", "dev", "blocks", "label", "path");
+ if (dev) {
+ show_host_dev(dev);
+ } else {
+ struct uclass *uc;
- continue;
- }
- struct host_block_dev *host_dev;
-
- host_dev = dev_get_plat(blk_dev->bdev);
- printf("%12lu %s\n", (unsigned long)blk_dev->lba,
- host_dev->filename);
+ uclass_id_foreach_dev(UCLASS_HOST, dev, uc)
+ show_host_dev(dev);
}
+
return 0;
}
static int do_host_dev(struct cmd_tbl *cmdtp, int flag, int argc,
char *const argv[])
{
- int dev;
- char *ep;
- struct blk_desc *blk_dev;
- int ret;
+ struct udevice *dev;
+ const char *label;
if (argc < 1 || argc > 3)
return CMD_RET_USAGE;
if (argc == 1) {
- if (host_curr_device < 0) {
+ struct host_sb_plat *plat;
+
+ dev = host_get_cur_dev();
+ if (!dev) {
printf("No current host device\n");
- return 1;
+ return CMD_RET_FAILURE;
}
- printf("Current host device %d\n", host_curr_device);
+ plat = dev_get_plat(dev);
+ printf("Current host device: %d: %s\n", dev_seq(dev),
+ plat->label);
return 0;
}
- dev = hextoul(argv[1], &ep);
- if (*ep) {
- printf("** Bad device specification %s **\n", argv[2]);
- return CMD_RET_USAGE;
- }
+ label = argv[1];
+ dev = parse_host_label(argv[1]);
+ if (!dev)
+ return CMD_RET_FAILURE;
- ret = host_get_dev_err(dev, &blk_dev);
- if (ret) {
- if (ret == -ENOENT)
- puts("Not bound to a backing file\n");
- else if (ret == -ENODEV)
- puts("Invalid host device number\n");
+ host_set_cur_dev(dev);
- return 1;
- }
-
- host_curr_device = dev;
return 0;
}
@@ -161,6 +222,7 @@
U_BOOT_CMD_MKENT(save, 6, 0, do_host_save, "", ""),
U_BOOT_CMD_MKENT(size, 3, 0, do_host_size, "", ""),
U_BOOT_CMD_MKENT(bind, 4, 0, do_host_bind, "", ""),
+ U_BOOT_CMD_MKENT(unbind, 4, 0, do_host_unbind, "", ""),
U_BOOT_CMD_MKENT(info, 3, 0, do_host_info, "", ""),
U_BOOT_CMD_MKENT(dev, 0, 1, do_host_dev, "", ""),
};
@@ -174,8 +236,7 @@
argc--;
argv++;
- c = find_cmd_tbl(argv[0], cmd_host_sub,
- ARRAY_SIZE(cmd_host_sub));
+ c = find_cmd_tbl(argv[0], cmd_host_sub, ARRAY_SIZE(cmd_host_sub));
if (c)
return c->cmd(cmdtp, flag, argc, argv);
@@ -192,10 +253,11 @@
"host save hostfs - <addr> <filename> <bytes> [<offset>] - "
"save a file to host\n"
"host size hostfs - <filename> - determine size of file on host\n"
- "host bind [-r] <dev> [<filename>] - bind \"host\" device to file\n"
+ "host bind [-r] <label> [<filename>] - bind \"host\" device to file\n"
" -r = mark as removable\n"
- "host info [<dev>] - show device binding & info\n"
- "host dev [<dev>] - Set or retrieve the current host device\n"
+ "host unbind <label> - unbind file from \"host\" device\n"
+ "host info [<label>] - show device binding & info\n"
+ "host dev [<label>] - set or retrieve the current host device\n"
"host commands use the \"hostfs\" device. The \"host\" device is used\n"
"with standard IO commands such as fatls or ext2load"
);