commit 9a082d2548de523c37f035cee7e0c280bad62bee
author Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com> Thu Sep 29 10:26:05 2022 +0530
committer Michal Simek <michal.simek@amd.com> Wed Oct 05 11:36:54 2022 +0200
tree 3db8ae16d13f07066182fd11ebfe6f74f0a694cf
parent e1a193b95177fb5325c07fa85810f640a8ed8687

net: Fix static checker warnings

Here are the smatch warning messages:

drivers/net/xilinx_axi_emac.c:324 axiemac_phy_init()
error: 'phydev' dereferencing possible ERR_PTR()

drivers/net/zynq_gem.c:340 zynq_phy_init()
error: 'priv->phydev' dereferencing possible ERR_PTR()

Fix by adding error checking before dereferencing the pointer.

Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>
Link: https://lore.kernel.org/r/20220929045605.23964-1-venkatesh.abbarapu@amd.com
Signed-off-by: Michal Simek <michal.simek@amd.com>

drivers/net/zynq_gem.c

diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
index 61a6c83..3f4357e 100644
--- a/drivers/net/zynq_gem.c
+++ b/drivers/net/zynq_gem.c
@@ -328,7 +328,7 @@
 
 	priv->phydev = phy_connect(priv->bus, priv->phyaddr, dev,
 				   priv->interface);
-	if (!priv->phydev)
+	if (IS_ERR_OR_NULL(priv->phydev))
 		return -ENODEV;
 
 	if (priv->max_speed) {