test: dm: add test for phandle access functions
Add unitary test for phandle access functions
- ofnode_count_phandle_with_args
- ofnode_parse_phandle_with_args
- dev_count_phandle_with_args
- dev_read_phandle_with_args
Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts
index e6da47d..cc37280 100644
--- a/arch/sandbox/dts/test.dts
+++ b/arch/sandbox/dts/test.dts
@@ -131,6 +131,7 @@
str-value = "test string";
interrupts-extended = <&irq 3 0>;
acpi,name = "GHIJ";
+ phandle-value = <&gpio_c 10>, <0xFFFFFFFF 20>, <&gpio_a 30>;
};
junk {
diff --git a/test/dm/ofnode.c b/test/dm/ofnode.c
index 4ae8d28..01ac3c2 100644
--- a/test/dm/ofnode.c
+++ b/test/dm/ofnode.c
@@ -103,6 +103,81 @@
}
DM_TEST(dm_test_ofnode_read, UT_TESTF_SCAN_PDATA | UT_TESTF_SCAN_FDT);
+static int dm_test_ofnode_phandle(struct unit_test_state *uts)
+{
+ struct ofnode_phandle_args args;
+ ofnode node;
+ int ret;
+ const char prop[] = "test-gpios";
+ const char cell[] = "#gpio-cells";
+ const char prop2[] = "phandle-value";
+
+ node = ofnode_path("/a-test");
+ ut_assert(ofnode_valid(node));
+
+ /* Test ofnode_count_phandle_with_args with cell name */
+ ret = ofnode_count_phandle_with_args(node, "missing", cell, 0);
+ ut_asserteq(-ENOENT, ret);
+ ret = ofnode_count_phandle_with_args(node, prop, "#invalid", 0);
+ ut_asserteq(-EINVAL, ret);
+ ret = ofnode_count_phandle_with_args(node, prop, cell, 0);
+ ut_asserteq(5, ret);
+
+ /* Test ofnode_parse_phandle_with_args with cell name */
+ ret = ofnode_parse_phandle_with_args(node, "missing", cell, 0, 0,
+ &args);
+ ut_asserteq(-ENOENT, ret);
+ ret = ofnode_parse_phandle_with_args(node, prop, "#invalid", 0, 0,
+ &args);
+ ut_asserteq(-EINVAL, ret);
+ ret = ofnode_parse_phandle_with_args(node, prop, cell, 0, 0, &args);
+ ut_assertok(ret);
+ ut_asserteq(1, args.args_count);
+ ut_asserteq(1, args.args[0]);
+ ret = ofnode_parse_phandle_with_args(node, prop, cell, 0, 1, &args);
+ ut_assertok(ret);
+ ut_asserteq(1, args.args_count);
+ ut_asserteq(4, args.args[0]);
+ ret = ofnode_parse_phandle_with_args(node, prop, cell, 0, 2, &args);
+ ut_assertok(ret);
+ ut_asserteq(5, args.args_count);
+ ut_asserteq(5, args.args[0]);
+ ut_asserteq(1, args.args[4]);
+ ret = ofnode_parse_phandle_with_args(node, prop, cell, 0, 3, &args);
+ ut_asserteq(-ENOENT, ret);
+ ret = ofnode_parse_phandle_with_args(node, prop, cell, 0, 4, &args);
+ ut_assertok(ret);
+ ut_asserteq(1, args.args_count);
+ ut_asserteq(12, args.args[0]);
+ ret = ofnode_parse_phandle_with_args(node, prop, cell, 0, 5, &args);
+ ut_asserteq(-ENOENT, ret);
+
+ /* Test ofnode_count_phandle_with_args with cell count */
+ ret = ofnode_count_phandle_with_args(node, "missing", NULL, 2);
+ ut_asserteq(-ENOENT, ret);
+ ret = ofnode_count_phandle_with_args(node, prop2, NULL, 1);
+ ut_asserteq(3, ret);
+
+ /* Test ofnode_parse_phandle_with_args with cell count */
+ ret = ofnode_parse_phandle_with_args(node, prop2, NULL, 1, 0, &args);
+ ut_assertok(ret);
+ ut_asserteq(1, ofnode_valid(args.node));
+ ut_asserteq(1, args.args_count);
+ ut_asserteq(10, args.args[0]);
+ ret = ofnode_parse_phandle_with_args(node, prop2, NULL, 1, 1, &args);
+ ut_asserteq(-EINVAL, ret);
+ ret = ofnode_parse_phandle_with_args(node, prop2, NULL, 1, 2, &args);
+ ut_assertok(ret);
+ ut_asserteq(1, ofnode_valid(args.node));
+ ut_asserteq(1, args.args_count);
+ ut_asserteq(30, args.args[0]);
+ ret = ofnode_parse_phandle_with_args(node, prop2, NULL, 1, 3, &args);
+ ut_asserteq(-ENOENT, ret);
+
+ return 0;
+}
+DM_TEST(dm_test_ofnode_phandle, UT_TESTF_SCAN_PDATA | UT_TESTF_SCAN_FDT);
+
static int dm_test_ofnode_read_chosen(struct unit_test_state *uts)
{
const char *str;
diff --git a/test/dm/test-fdt.c b/test/dm/test-fdt.c
index 26d57f4..cc12419 100644
--- a/test/dm/test-fdt.c
+++ b/test/dm/test-fdt.c
@@ -968,6 +968,71 @@
}
DM_TEST(dm_test_read_int_index, UT_TESTF_SCAN_PDATA | UT_TESTF_SCAN_FDT);
+static int dm_test_read_phandle(struct unit_test_state *uts)
+{
+ struct udevice *dev;
+ struct ofnode_phandle_args args;
+ int ret;
+ const char prop[] = "test-gpios";
+ const char cell[] = "#gpio-cells";
+ const char prop2[] = "phandle-value";
+
+ ut_assertok(uclass_first_device_err(UCLASS_TEST_FDT, &dev));
+ ut_asserteq_str("a-test", dev->name);
+
+ /* Test dev_count_phandle_with_args with cell name */
+ ret = dev_count_phandle_with_args(dev, "missing", cell, 0);
+ ut_asserteq(-ENOENT, ret);
+ ret = dev_count_phandle_with_args(dev, prop, "#invalid", 0);
+ ut_asserteq(-EINVAL, ret);
+ ut_asserteq(5, dev_count_phandle_with_args(dev, prop, cell, 0));
+
+ /* Test dev_read_phandle_with_args with cell name */
+ ret = dev_read_phandle_with_args(dev, "missing", cell, 0, 0, &args);
+ ut_asserteq(-ENOENT, ret);
+ ret = dev_read_phandle_with_args(dev, prop, "#invalid", 0, 0, &args);
+ ut_asserteq(-EINVAL, ret);
+ ut_assertok(dev_read_phandle_with_args(dev, prop, cell, 0, 0, &args));
+ ut_asserteq(1, args.args_count);
+ ut_asserteq(1, args.args[0]);
+ ut_assertok(dev_read_phandle_with_args(dev, prop, cell, 0, 1, &args));
+ ut_asserteq(1, args.args_count);
+ ut_asserteq(4, args.args[0]);
+ ut_assertok(dev_read_phandle_with_args(dev, prop, cell, 0, 2, &args));
+ ut_asserteq(5, args.args_count);
+ ut_asserteq(5, args.args[0]);
+ ut_asserteq(1, args.args[4]);
+ ret = dev_read_phandle_with_args(dev, prop, cell, 0, 3, &args);
+ ut_asserteq(-ENOENT, ret);
+ ut_assertok(dev_read_phandle_with_args(dev, prop, cell, 0, 4, &args));
+ ut_asserteq(1, args.args_count);
+ ut_asserteq(12, args.args[0]);
+ ret = dev_read_phandle_with_args(dev, prop, cell, 0, 5, &args);
+ ut_asserteq(-ENOENT, ret);
+
+ /* Test dev_count_phandle_with_args with cell count */
+ ret = dev_count_phandle_with_args(dev, "missing", NULL, 2);
+ ut_asserteq(-ENOENT, ret);
+ ut_asserteq(3, dev_count_phandle_with_args(dev, prop2, NULL, 1));
+
+ /* Test dev_read_phandle_with_args with cell count */
+ ut_assertok(dev_read_phandle_with_args(dev, prop2, NULL, 1, 0, &args));
+ ut_asserteq(1, ofnode_valid(args.node));
+ ut_asserteq(1, args.args_count);
+ ut_asserteq(10, args.args[0]);
+ ret = dev_read_phandle_with_args(dev, prop2, NULL, 1, 1, &args);
+ ut_asserteq(-EINVAL, ret);
+ ut_assertok(dev_read_phandle_with_args(dev, prop2, NULL, 1, 2, &args));
+ ut_asserteq(1, ofnode_valid(args.node));
+ ut_asserteq(1, args.args_count);
+ ut_asserteq(30, args.args[0]);
+ ret = dev_read_phandle_with_args(dev, prop2, NULL, 1, 3, &args);
+ ut_asserteq(-ENOENT, ret);
+
+ return 0;
+}
+DM_TEST(dm_test_read_phandle, UT_TESTF_SCAN_PDATA | UT_TESTF_SCAN_FDT);
+
/* Test iteration through devices by drvdata */
static int dm_test_uclass_drvdata(struct unit_test_state *uts)
{