blob: 6b156f152de514d20aed4b1be9a9e783d3c4a8d4 [file] [log] [blame]
Tom Rini83d290c2018-05-06 17:58:06 -04001# SPDX-License-Identifier: GPL-2.0+
Simon Glass190064b2014-08-09 15:33:00 -06002# Copyright (c) 2014 Google, Inc
3#
Simon Glass190064b2014-08-09 15:33:00 -06004
5import errno
6import glob
7import os
8import shutil
Lothar Waßmann409fc022018-04-08 05:14:11 -06009import sys
Simon Glass190064b2014-08-09 15:33:00 -060010import threading
11
12import command
13import gitutil
14
Simon Glass88c8dcf2015-02-05 22:06:13 -070015RETURN_CODE_RETRY = -1
16
Thierry Redingf3d015c2014-08-19 10:22:39 +020017def Mkdir(dirname, parents = False):
Simon Glass190064b2014-08-09 15:33:00 -060018 """Make a directory if it doesn't already exist.
19
20 Args:
21 dirname: Directory to create
22 """
23 try:
Thierry Redingf3d015c2014-08-19 10:22:39 +020024 if parents:
25 os.makedirs(dirname)
26 else:
27 os.mkdir(dirname)
Simon Glass190064b2014-08-09 15:33:00 -060028 except OSError as err:
29 if err.errno == errno.EEXIST:
Lothar Waßmann409fc022018-04-08 05:14:11 -060030 if os.path.realpath('.') == os.path.realpath(dirname):
31 print "Cannot create the current working directory '%s'!" % dirname
32 sys.exit(1)
Simon Glass190064b2014-08-09 15:33:00 -060033 pass
34 else:
35 raise
36
37class BuilderJob:
38 """Holds information about a job to be performed by a thread
39
40 Members:
41 board: Board object to build
42 commits: List of commit options to build.
43 """
44 def __init__(self):
45 self.board = None
46 self.commits = []
47
48
49class ResultThread(threading.Thread):
50 """This thread processes results from builder threads.
51
52 It simply passes the results on to the builder. There is only one
53 result thread, and this helps to serialise the build output.
54 """
55 def __init__(self, builder):
56 """Set up a new result thread
57
58 Args:
59 builder: Builder which will be sent each result
60 """
61 threading.Thread.__init__(self)
62 self.builder = builder
63
64 def run(self):
65 """Called to start up the result thread.
66
67 We collect the next result job and pass it on to the build.
68 """
69 while True:
70 result = self.builder.out_queue.get()
71 self.builder.ProcessResult(result)
72 self.builder.out_queue.task_done()
73
74
75class BuilderThread(threading.Thread):
76 """This thread builds U-Boot for a particular board.
77
78 An input queue provides each new job. We run 'make' to build U-Boot
79 and then pass the results on to the output queue.
80
81 Members:
82 builder: The builder which contains information we might need
83 thread_num: Our thread number (0-n-1), used to decide on a
84 temporary directory
85 """
Stephen Warrenf79f1e02016-04-11 10:48:44 -060086 def __init__(self, builder, thread_num, incremental, per_board_out_dir):
Simon Glass190064b2014-08-09 15:33:00 -060087 """Set up a new builder thread"""
88 threading.Thread.__init__(self)
89 self.builder = builder
90 self.thread_num = thread_num
Stephen Warrenf79f1e02016-04-11 10:48:44 -060091 self.incremental = incremental
92 self.per_board_out_dir = per_board_out_dir
Simon Glass190064b2014-08-09 15:33:00 -060093
94 def Make(self, commit, brd, stage, cwd, *args, **kwargs):
95 """Run 'make' on a particular commit and board.
96
97 The source code will already be checked out, so the 'commit'
98 argument is only for information.
99
100 Args:
101 commit: Commit object that is being built
102 brd: Board object that is being built
103 stage: Stage of the build. Valid stages are:
Roger Meierfd18a892014-08-20 22:10:29 +0200104 mrproper - can be called to clean source
Simon Glass190064b2014-08-09 15:33:00 -0600105 config - called to configure for a board
106 build - the main make invocation - it does the build
107 args: A list of arguments to pass to 'make'
108 kwargs: A list of keyword arguments to pass to command.RunPipe()
109
110 Returns:
111 CommandResult object
112 """
113 return self.builder.do_make(commit, brd, stage, cwd, *args,
114 **kwargs)
115
Simon Glassa9401b22016-11-16 14:09:25 -0700116 def RunCommit(self, commit_upto, brd, work_dir, do_config, config_only,
Simon Glassb50113f2016-11-13 14:25:51 -0700117 force_build, force_build_failures):
Simon Glass190064b2014-08-09 15:33:00 -0600118 """Build a particular commit.
119
120 If the build is already done, and we are not forcing a build, we skip
121 the build and just return the previously-saved results.
122
123 Args:
124 commit_upto: Commit number to build (0...n-1)
125 brd: Board object to build
126 work_dir: Directory to which the source will be checked out
127 do_config: True to run a make <board>_defconfig on the source
Simon Glassa9401b22016-11-16 14:09:25 -0700128 config_only: Only configure the source, do not build it
Simon Glass190064b2014-08-09 15:33:00 -0600129 force_build: Force a build even if one was previously done
130 force_build_failures: Force a bulid if the previous result showed
131 failure
132
133 Returns:
134 tuple containing:
135 - CommandResult object containing the results of the build
136 - boolean indicating whether 'make config' is still needed
137 """
138 # Create a default result - it will be overwritte by the call to
139 # self.Make() below, in the event that we do a build.
140 result = command.CommandResult()
141 result.return_code = 0
142 if self.builder.in_tree:
143 out_dir = work_dir
144 else:
Stephen Warrenf79f1e02016-04-11 10:48:44 -0600145 if self.per_board_out_dir:
146 out_rel_dir = os.path.join('..', brd.target)
147 else:
148 out_rel_dir = 'build'
149 out_dir = os.path.join(work_dir, out_rel_dir)
Simon Glass190064b2014-08-09 15:33:00 -0600150
151 # Check if the job was already completed last time
152 done_file = self.builder.GetDoneFile(commit_upto, brd.target)
153 result.already_done = os.path.exists(done_file)
154 will_build = (force_build or force_build_failures or
155 not result.already_done)
Simon Glassfb3954f2014-09-05 19:00:17 -0600156 if result.already_done:
Simon Glass190064b2014-08-09 15:33:00 -0600157 # Get the return code from that build and use it
158 with open(done_file, 'r') as fd:
Simon Glasse74429b2018-12-10 09:05:23 -0700159 try:
160 result.return_code = int(fd.readline())
161 except ValueError:
162 # The file may be empty due to running out of disk space.
163 # Try a rebuild
164 result.return_code = RETURN_CODE_RETRY
Simon Glass88c8dcf2015-02-05 22:06:13 -0700165
166 # Check the signal that the build needs to be retried
167 if result.return_code == RETURN_CODE_RETRY:
168 will_build = True
169 elif will_build:
Simon Glassfb3954f2014-09-05 19:00:17 -0600170 err_file = self.builder.GetErrFile(commit_upto, brd.target)
171 if os.path.exists(err_file) and os.stat(err_file).st_size:
172 result.stderr = 'bad'
173 elif not force_build:
174 # The build passed, so no need to build it again
175 will_build = False
Simon Glass190064b2014-08-09 15:33:00 -0600176
177 if will_build:
178 # We are going to have to build it. First, get a toolchain
179 if not self.toolchain:
180 try:
181 self.toolchain = self.builder.toolchains.Select(brd.arch)
182 except ValueError as err:
183 result.return_code = 10
184 result.stdout = ''
185 result.stderr = str(err)
186 # TODO(sjg@chromium.org): This gets swallowed, but needs
187 # to be reported.
188
189 if self.toolchain:
190 # Checkout the right commit
191 if self.builder.commits:
192 commit = self.builder.commits[commit_upto]
193 if self.builder.checkout:
194 git_dir = os.path.join(work_dir, '.git')
195 gitutil.Checkout(commit.hash, git_dir, work_dir,
196 force=True)
197 else:
198 commit = 'current'
199
200 # Set up the environment and command line
Simon Glassbb1501f2014-12-01 17:34:00 -0700201 env = self.toolchain.MakeEnvironment(self.builder.full_path)
Simon Glass190064b2014-08-09 15:33:00 -0600202 Mkdir(out_dir)
203 args = []
204 cwd = work_dir
Simon Glass48c1b6a2014-08-28 09:43:42 -0600205 src_dir = os.path.realpath(work_dir)
Simon Glass190064b2014-08-09 15:33:00 -0600206 if not self.builder.in_tree:
207 if commit_upto is None:
208 # In this case we are building in the original source
209 # directory (i.e. the current directory where buildman
210 # is invoked. The output directory is set to this
211 # thread's selected work directory.
212 #
213 # Symlinks can confuse U-Boot's Makefile since
214 # we may use '..' in our path, so remove them.
Stephen Warrenf79f1e02016-04-11 10:48:44 -0600215 out_dir = os.path.realpath(out_dir)
216 args.append('O=%s' % out_dir)
Simon Glass190064b2014-08-09 15:33:00 -0600217 cwd = None
Simon Glass48c1b6a2014-08-28 09:43:42 -0600218 src_dir = os.getcwd()
Simon Glass190064b2014-08-09 15:33:00 -0600219 else:
Stephen Warrenf79f1e02016-04-11 10:48:44 -0600220 args.append('O=%s' % out_rel_dir)
Tom Rinif5e5ece2015-04-01 07:47:41 -0400221 if self.builder.verbose_build:
222 args.append('V=1')
223 else:
Simon Glassd2ce6582014-12-01 17:34:07 -0700224 args.append('-s')
Simon Glass190064b2014-08-09 15:33:00 -0600225 if self.builder.num_jobs is not None:
226 args.extend(['-j', str(self.builder.num_jobs)])
Daniel Schwierzeck2371d1b2018-01-26 16:31:05 +0100227 if self.builder.warnings_as_errors:
228 args.append('KCFLAGS=-Werror')
Simon Glass190064b2014-08-09 15:33:00 -0600229 config_args = ['%s_defconfig' % brd.target]
230 config_out = ''
231 args.extend(self.builder.toolchains.GetMakeArguments(brd))
Simon Glass00beb242019-01-07 16:44:20 -0700232 args.extend(self.toolchain.MakeArgs())
Simon Glass190064b2014-08-09 15:33:00 -0600233
234 # If we need to reconfigure, do that now
235 if do_config:
Stephen Warrenf79f1e02016-04-11 10:48:44 -0600236 config_out = ''
237 if not self.incremental:
238 result = self.Make(commit, brd, 'mrproper', cwd,
239 'mrproper', *args, env=env)
240 config_out += result.combined
Simon Glass190064b2014-08-09 15:33:00 -0600241 result = self.Make(commit, brd, 'config', cwd,
242 *(args + config_args), env=env)
Simon Glass40f11fc2015-02-05 22:06:12 -0700243 config_out += result.combined
Simon Glass190064b2014-08-09 15:33:00 -0600244 do_config = False # No need to configure next time
245 if result.return_code == 0:
Simon Glassa9401b22016-11-16 14:09:25 -0700246 if config_only:
Simon Glassb50113f2016-11-13 14:25:51 -0700247 args.append('cfg')
Simon Glass190064b2014-08-09 15:33:00 -0600248 result = self.Make(commit, brd, 'build', cwd, *args,
249 env=env)
Simon Glass48c1b6a2014-08-28 09:43:42 -0600250 result.stderr = result.stderr.replace(src_dir + '/', '')
Simon Glass40f11fc2015-02-05 22:06:12 -0700251 if self.builder.verbose_build:
252 result.stdout = config_out + result.stdout
Simon Glass190064b2014-08-09 15:33:00 -0600253 else:
254 result.return_code = 1
255 result.stderr = 'No tool chain for %s\n' % brd.arch
256 result.already_done = False
257
258 result.toolchain = self.toolchain
259 result.brd = brd
260 result.commit_upto = commit_upto
261 result.out_dir = out_dir
262 return result, do_config
263
264 def _WriteResult(self, result, keep_outputs):
265 """Write a built result to the output directory.
266
267 Args:
268 result: CommandResult object containing result to write
269 keep_outputs: True to store the output binaries, False
270 to delete them
271 """
272 # Fatal error
273 if result.return_code < 0:
274 return
275
Simon Glass88c8dcf2015-02-05 22:06:13 -0700276 # If we think this might have been aborted with Ctrl-C, record the
277 # failure but not that we are 'done' with this board. A retry may fix
278 # it.
279 maybe_aborted = result.stderr and 'No child processes' in result.stderr
Simon Glass190064b2014-08-09 15:33:00 -0600280
281 if result.already_done:
282 return
283
284 # Write the output and stderr
285 output_dir = self.builder._GetOutputDir(result.commit_upto)
286 Mkdir(output_dir)
287 build_dir = self.builder.GetBuildDir(result.commit_upto,
288 result.brd.target)
289 Mkdir(build_dir)
290
291 outfile = os.path.join(build_dir, 'log')
292 with open(outfile, 'w') as fd:
293 if result.stdout:
Daniel Schwierzeckaafbe822017-06-08 03:07:09 +0200294 # We don't want unicode characters in log files
295 fd.write(result.stdout.decode('UTF-8').encode('ASCII', 'replace'))
Simon Glass190064b2014-08-09 15:33:00 -0600296
297 errfile = self.builder.GetErrFile(result.commit_upto,
298 result.brd.target)
299 if result.stderr:
300 with open(errfile, 'w') as fd:
Daniel Schwierzeckaafbe822017-06-08 03:07:09 +0200301 # We don't want unicode characters in log files
302 fd.write(result.stderr.decode('UTF-8').encode('ASCII', 'replace'))
Simon Glass190064b2014-08-09 15:33:00 -0600303 elif os.path.exists(errfile):
304 os.remove(errfile)
305
306 if result.toolchain:
307 # Write the build result and toolchain information.
308 done_file = self.builder.GetDoneFile(result.commit_upto,
309 result.brd.target)
310 with open(done_file, 'w') as fd:
Simon Glass88c8dcf2015-02-05 22:06:13 -0700311 if maybe_aborted:
312 # Special code to indicate we need to retry
313 fd.write('%s' % RETURN_CODE_RETRY)
314 else:
315 fd.write('%s' % result.return_code)
Simon Glass190064b2014-08-09 15:33:00 -0600316 with open(os.path.join(build_dir, 'toolchain'), 'w') as fd:
317 print >>fd, 'gcc', result.toolchain.gcc
318 print >>fd, 'path', result.toolchain.path
319 print >>fd, 'cross', result.toolchain.cross
320 print >>fd, 'arch', result.toolchain.arch
321 fd.write('%s' % result.return_code)
322
Simon Glass190064b2014-08-09 15:33:00 -0600323 # Write out the image and function size information and an objdump
Simon Glassbb1501f2014-12-01 17:34:00 -0700324 env = result.toolchain.MakeEnvironment(self.builder.full_path)
Simon Glass190064b2014-08-09 15:33:00 -0600325 lines = []
326 for fname in ['u-boot', 'spl/u-boot-spl']:
327 cmd = ['%snm' % self.toolchain.cross, '--size-sort', fname]
328 nm_result = command.RunPipe([cmd], capture=True,
329 capture_stderr=True, cwd=result.out_dir,
330 raise_on_error=False, env=env)
331 if nm_result.stdout:
332 nm = self.builder.GetFuncSizesFile(result.commit_upto,
333 result.brd.target, fname)
334 with open(nm, 'w') as fd:
335 print >>fd, nm_result.stdout,
336
337 cmd = ['%sobjdump' % self.toolchain.cross, '-h', fname]
338 dump_result = command.RunPipe([cmd], capture=True,
339 capture_stderr=True, cwd=result.out_dir,
340 raise_on_error=False, env=env)
341 rodata_size = ''
342 if dump_result.stdout:
343 objdump = self.builder.GetObjdumpFile(result.commit_upto,
344 result.brd.target, fname)
345 with open(objdump, 'w') as fd:
346 print >>fd, dump_result.stdout,
347 for line in dump_result.stdout.splitlines():
348 fields = line.split()
349 if len(fields) > 5 and fields[1] == '.rodata':
350 rodata_size = fields[2]
351
352 cmd = ['%ssize' % self.toolchain.cross, fname]
353 size_result = command.RunPipe([cmd], capture=True,
354 capture_stderr=True, cwd=result.out_dir,
355 raise_on_error=False, env=env)
356 if size_result.stdout:
357 lines.append(size_result.stdout.splitlines()[1] + ' ' +
358 rodata_size)
359
Alex Kiernan0ddc5102018-05-31 04:48:33 +0000360 # Extract the environment from U-Boot and dump it out
361 cmd = ['%sobjcopy' % self.toolchain.cross, '-O', 'binary',
362 '-j', '.rodata.default_environment',
363 'env/built-in.o', 'uboot.env']
364 command.RunPipe([cmd], capture=True,
365 capture_stderr=True, cwd=result.out_dir,
366 raise_on_error=False, env=env)
367 ubootenv = os.path.join(result.out_dir, 'uboot.env')
368 self.CopyFiles(result.out_dir, build_dir, '', ['uboot.env'])
369
Simon Glass190064b2014-08-09 15:33:00 -0600370 # Write out the image sizes file. This is similar to the output
371 # of binutil's 'size' utility, but it omits the header line and
372 # adds an additional hex value at the end of each line for the
373 # rodata size
374 if len(lines):
375 sizes = self.builder.GetSizesFile(result.commit_upto,
376 result.brd.target)
377 with open(sizes, 'w') as fd:
378 print >>fd, '\n'.join(lines)
379
Simon Glass970f9322015-02-05 22:06:14 -0700380 # Write out the configuration files, with a special case for SPL
381 for dirname in ['', 'spl', 'tpl']:
382 self.CopyFiles(result.out_dir, build_dir, dirname, ['u-boot.cfg',
383 'spl/u-boot-spl.cfg', 'tpl/u-boot-tpl.cfg', '.config',
384 'include/autoconf.mk', 'include/generated/autoconf.h'])
385
Simon Glass190064b2014-08-09 15:33:00 -0600386 # Now write the actual build output
387 if keep_outputs:
Tom Rini0eb4c042015-03-20 10:50:38 -0400388 self.CopyFiles(result.out_dir, build_dir, '', ['u-boot*', '*.bin',
Tom Rinidd592112015-04-27 11:34:38 -0400389 '*.map', '*.img', 'MLO', 'SPL', 'include/autoconf.mk',
Tom Rini0eb4c042015-03-20 10:50:38 -0400390 'spl/u-boot-spl*'])
Simon Glass190064b2014-08-09 15:33:00 -0600391
Simon Glass970f9322015-02-05 22:06:14 -0700392 def CopyFiles(self, out_dir, build_dir, dirname, patterns):
393 """Copy files from the build directory to the output.
394
395 Args:
396 out_dir: Path to output directory containing the files
397 build_dir: Place to copy the files
398 dirname: Source directory, '' for normal U-Boot, 'spl' for SPL
399 patterns: A list of filenames (strings) to copy, each relative
400 to the build directory
401 """
402 for pattern in patterns:
403 file_list = glob.glob(os.path.join(out_dir, dirname, pattern))
404 for fname in file_list:
405 target = os.path.basename(fname)
406 if dirname:
407 base, ext = os.path.splitext(target)
408 if ext:
409 target = '%s-%s%s' % (base, dirname, ext)
410 shutil.copy(fname, os.path.join(build_dir, target))
Simon Glass190064b2014-08-09 15:33:00 -0600411
412 def RunJob(self, job):
413 """Run a single job
414
415 A job consists of a building a list of commits for a particular board.
416
417 Args:
418 job: Job to build
419 """
420 brd = job.board
421 work_dir = self.builder.GetThreadDir(self.thread_num)
422 self.toolchain = None
423 if job.commits:
424 # Run 'make board_defconfig' on the first commit
425 do_config = True
426 commit_upto = 0
427 force_build = False
428 for commit_upto in range(0, len(job.commits), job.step):
429 result, request_config = self.RunCommit(commit_upto, brd,
Simon Glassa9401b22016-11-16 14:09:25 -0700430 work_dir, do_config, self.builder.config_only,
Simon Glass190064b2014-08-09 15:33:00 -0600431 force_build or self.builder.force_build,
432 self.builder.force_build_failures)
433 failed = result.return_code or result.stderr
434 did_config = do_config
435 if failed and not do_config:
436 # If our incremental build failed, try building again
437 # with a reconfig.
438 if self.builder.force_config_on_failure:
439 result, request_config = self.RunCommit(commit_upto,
Simon Glassb50113f2016-11-13 14:25:51 -0700440 brd, work_dir, True, False, True, False)
Simon Glass190064b2014-08-09 15:33:00 -0600441 did_config = True
442 if not self.builder.force_reconfig:
443 do_config = request_config
444
445 # If we built that commit, then config is done. But if we got
446 # an warning, reconfig next time to force it to build the same
447 # files that created warnings this time. Otherwise an
448 # incremental build may not build the same file, and we will
449 # think that the warning has gone away.
450 # We could avoid this by using -Werror everywhere...
451 # For errors, the problem doesn't happen, since presumably
452 # the build stopped and didn't generate output, so will retry
453 # that file next time. So we could detect warnings and deal
454 # with them specially here. For now, we just reconfigure if
455 # anything goes work.
456 # Of course this is substantially slower if there are build
457 # errors/warnings (e.g. 2-3x slower even if only 10% of builds
458 # have problems).
459 if (failed and not result.already_done and not did_config and
460 self.builder.force_config_on_failure):
461 # If this build failed, try the next one with a
462 # reconfigure.
463 # Sometimes if the board_config.h file changes it can mess
464 # with dependencies, and we get:
465 # make: *** No rule to make target `include/autoconf.mk',
466 # needed by `depend'.
467 do_config = True
468 force_build = True
469 else:
470 force_build = False
471 if self.builder.force_config_on_failure:
472 if failed:
473 do_config = True
474 result.commit_upto = commit_upto
475 if result.return_code < 0:
476 raise ValueError('Interrupt')
477
478 # We have the build results, so output the result
479 self._WriteResult(result, job.keep_outputs)
480 self.builder.out_queue.put(result)
481 else:
482 # Just build the currently checked-out build
483 result, request_config = self.RunCommit(None, brd, work_dir, True,
Simon Glassa9401b22016-11-16 14:09:25 -0700484 self.builder.config_only, True,
Simon Glassb50113f2016-11-13 14:25:51 -0700485 self.builder.force_build_failures)
Simon Glass190064b2014-08-09 15:33:00 -0600486 result.commit_upto = 0
487 self._WriteResult(result, job.keep_outputs)
488 self.builder.out_queue.put(result)
489
490 def run(self):
491 """Our thread's run function
492
493 This thread picks a job from the queue, runs it, and then goes to the
494 next job.
495 """
Simon Glass190064b2014-08-09 15:33:00 -0600496 while True:
497 job = self.builder.queue.get()
Simon Glass2880e6b2016-09-18 16:48:38 -0600498 self.RunJob(job)
Simon Glass190064b2014-08-09 15:33:00 -0600499 self.builder.queue.task_done()